Re-introduce ASL in the functions names

Author: bstpierr

Example/Core/Tests/FIRLoggerTest.m

@@ -20,5 +20,6 @@ @interface FIRLoggerTest : FIRTestCase
 @end
 
 @implementation FIRLoggerTest
-// TODO(bstpierre):Create FIRLogger tests which do not depend on GULLogger implementation details.
+
+// TODO(bstpierre): Test FIRLogger functionality separate from GULLogger.
 @end

Firebase/Core/FIRLogger.m

@@ -64,7 +64,7 @@
 static NSRegularExpression *sMessageCodeRegex;
 #endif
 
-void FIRLoggerInitialize() {
+void FIRLoggerInitializeASL() {
   dispatch_once(&sFIRLoggerOnceToken, ^{
     // Register Firebase Version with GULLogger.
     GULLoggerRegisterVersion(FIRVersionString);
@@ -87,7 +87,7 @@ void FIRLoggerInitialize() {
       [sFIRLoggerUserDefaults setBool:YES forKey:kFIRPersistedDebugModeKey];
       forceDebugMode = YES;
     }
-    GULLoggerInitialize();
+    GULLoggerInitializeASL();
     if (overrideSTDERR) {
       GULLoggerEnableSTDERR();
     }
@@ -102,7 +102,7 @@ void FIRLoggerInitialize() {
 }
 
 void FIRSetLoggerLevel(FIRLoggerLevel loggerLevel) {
-  FIRLoggerInitialize();
+  FIRLoggerInitializeASL();
   GULSetLoggerLevel((GULLoggerLevel)loggerLevel);
 }
 
@@ -114,7 +114,7 @@ void FIRSetLoggerLevel(FIRLoggerLevel loggerLevel) {
  */
 __attribute__((no_sanitize("thread"))) BOOL FIRIsLoggableLevel(FIRLoggerLevel loggerLevel,
                                                                BOOL analyticsComponent) {
-  FIRLoggerInitialize();
+  FIRLoggerInitializeASL();
   if (sFIRAnalyticsDebugMode && analyticsComponent) {
     return YES;
   }
@@ -126,7 +126,7 @@ void FIRLogBasic(FIRLoggerLevel level,
                  NSString *messageCode,
                  NSString *message,
                  va_list args_ptr) {
-  FIRLoggerInitialize();
+  FIRLoggerInitializeASL();
   GULLogBasic((GULLoggerLevel)level, service,
               sFIRAnalyticsDebugMode && [kFIRLoggerAnalytics isEqualToString:service], messageCode,
               message, args_ptr);

GoogleUtilities/Logger/GULLogger.m

@@ -25,6 +25,10 @@ void GULLoggerInitialize(void) {
   [GULLogger.logger initializeLogger];
 }
 
+void GULLoggerInitializeASL(void) {
+  GULLoggerInitialize();
+}
+
 void GULLoggerEnableSTDERR(void) {
   [GULLogger.logger printToSTDERR];
 }

GoogleUtilities/Logger/Private/GULLogger.h

@@ -28,9 +28,20 @@ extern "C" {
 
 /**
  * Initialize the default GULLogger.
+ *
+ * @discussion On iOS 9 and earlier. GULLogger will use ASL. For iOS 10 and later, os_log is used.
  */
 extern void GULLoggerInitialize(void);
 
+/**
+ * Initialize GULLogger.
+ *
+ * @discussion This version should no longer be used. ASL is deprecated by Apple to be replaced by
+ *             os_log. Calls to this function are redirected to GULLoggerInitialize to ensure
+ *             functionality on all iOS versions.
+ */
+extern void GULLoggerInitializeASL(void);
+
 /**
  * Override log level to Debug.
  */