Skip to content

Commit f6ffd3a

Browse files
bbarenblatwilhuff
authored andcommitted
Eliminate -Wimplicit-fallthrough triggers (#1553)
Replace fallthrough comments with `ABSL_FALLTHROUGH_INTENDED`, allowing clean building with -Wimplicit-fallthrough.
1 parent 06d0800 commit f6ffd3a

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

Firestore/Source/Local/FSTLevelDBMigrations.mm

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
#import "Firestore/Source/Local/FSTLevelDBQueryCache.h"
2424

2525
#include "Firestore/core/src/firebase/firestore/util/hard_assert.h"
26+
#include "absl/base/macros.h"
2627
#include "absl/strings/match.h"
2728
#include "leveldb/write_batch.h"
2829

@@ -108,11 +109,11 @@ + (void)runMigrationsWithTransaction:(firebase::firestore::local::LevelDbTransac
108109
switch (currentVersion) {
109110
case 0:
110111
EnsureTargetGlobal(transaction);
111-
// Fallthrough
112+
ABSL_FALLTHROUGH_INTENDED;
112113
case 1:
113114
// We're now guaranteed that the target global exists. We can safely add a count to it.
114115
AddTargetCount(transaction);
115-
// Fallthrough
116+
ABSL_FALLTHROUGH_INTENDED;
116117
default:
117118
if (currentVersion < kSchemaVersion) {
118119
SaveVersion(kSchemaVersion, transaction);

0 commit comments

Comments
 (0)