Skip to content

Commit d195f6e

Browse files
authored
ifdef out flaky Database Integration Tests (#1808)
1 parent e82f110 commit d195f6e

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

Example/Database/Tests/Integration/FData.m

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -742,6 +742,7 @@ - (void) testNumChildrenWorksCorrectly {
742742
}];
743743
}
744744

745+
#ifdef FLAKY_TEST
745746
- (void) testSettingANodeWithChildrenToAPrimitiveAndBack {
746747
// Can't tolerate stale data; so disable persistence.
747748
FTupleFirebase* tuple = [FTestHelpers getRandomNodePairWithoutPersistence];
@@ -827,6 +828,7 @@ - (void) testSettingANodeWithChildrenToAPrimitiveAndBack {
827828

828829
XCTAssertTrue(done, @"Properly finished");
829830
}
831+
#endif
830832

831833
- (void) testWriteLeafRemoveLeafAddChildToRemovedNode {
832834
FTupleFirebase* refs = [FTestHelpers getRandomNodePair];
@@ -2188,6 +2190,7 @@ - (void) testLargeNumbers {
21882190
XCTAssertTrue([result isEqualToNumber:toSet], @"Should get back same number");
21892191
}
21902192

2193+
#ifdef FLAKY_TEST
21912194
- (void) testParentDeleteShadowsChildListeners {
21922195
FTupleFirebase* refs = [FTestHelpers getRandomNodePair];
21932196
FIRDatabaseReference * writer = refs.one;
@@ -2213,6 +2216,7 @@ - (void) testParentDeleteShadowsChildListeners {
22132216
WAIT_FOR(done);
22142217
[deleter removeAllObservers];
22152218
}
2219+
#endif
22162220

22172221
- (void) testParentDeleteShadowsChildListenersWithNonDefaultQuery {
22182222
FTupleFirebase* refs = [FTestHelpers getRandomNodePair];

Example/Database/Tests/Integration/FIRDatabaseQueryTests.m

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2465,7 +2465,7 @@ - (void) testListenForChildAddedWithLimitEnsureEventsFireProperly {
24652465
WAIT_FOR(count == 3);
24662466
}
24672467

2468-
2468+
#ifdef FLAKY_TEST
24692469
- (void) testListenForChildChangedWithLimitEnsureEventsFireProperly {
24702470
FTupleFirebase* refs = [FTestHelpers getRandomNodePair];
24712471
FIRDatabaseReference * writer = refs.one;
@@ -2502,6 +2502,7 @@ - (void) testListenForChildChangedWithLimitEnsureEventsFireProperly {
25022502

25032503
WAIT_FOR(count == 3);
25042504
}
2505+
#endif
25052506

25062507
- (void) testListenForChildRemovedWithLimitEnsureEventsFireProperly {
25072508
FTupleFirebase* refs = [FTestHelpers getRandomNodePair];

0 commit comments

Comments
 (0)