1414 * limitations under the License.
1515 */
1616
17- #import " Firestore/Source/Local/FSTLevelDBMigrations .h"
17+ #include " Firestore/core/src/firebase/firestore/local/leveldb_migrations .h"
1818
1919#include < string>
20+ #include < utility>
2021
21- #import " Firestore/Protos/objc/firestore/local/Target.pbobjc.h"
22- #import " Firestore/Source/Local/FSTLevelDBQueryCache.h"
23-
22+ #include " Firestore/Protos/nanopb/firestore/local/target.nanopb.h"
2423#include " Firestore/core/src/firebase/firestore/local/leveldb_key.h"
25- #include " Firestore/core/src/firebase/firestore/util/hard_assert.h"
26- #include " absl/base/macros.h"
27- #include " absl/memory/memory.h"
24+ #include " Firestore/core/src/firebase/firestore/nanopb/writer.h"
2825#include " absl/strings/match.h"
29- #include " leveldb/write_batch.h"
3026
31- NS_ASSUME_NONNULL_BEGIN
27+ namespace firebase {
28+ namespace firestore {
29+ namespace local {
30+
31+ using leveldb::Iterator;
32+ using leveldb::Slice;
33+ using leveldb::Status;
34+ using leveldb::WriteOptions;
35+ using nanopb::Writer;
36+
37+ namespace {
3238
3339/* *
3440 * Schema version for the iOS client.
3541 *
36- * Note that tables aren't a concept in LevelDB. They exist in our schema as just prefixes on keys.
37- * This means tables don't need to be created but they also can't easily be dropped and re-created.
42+ * Note that tables aren't a concept in LevelDB. They exist in our schema as
43+ * just prefixes on keys. This means tables don't need to be created but they
44+ * also can't easily be dropped and re-created.
3845 *
3946 * Migrations:
40- * * Migration 1 used to ensure the target_global row existed, without clearing it. No longer
41- * required because migration 3 unconditionally clears it.
42- * * Migration 2 used to ensure that the target_global row had a correct count of targets. No
43- * longer required because migration 3 deletes them all.
44- * * Migration 3 deletes the entire query cache to deal with cache corruption related to
45- * limbo resolution. Addresses https://github.com/firebase/firebase-ios-sdk/issues/1548.
47+ * * Migration 1 used to ensure the target_global row existed, without
48+ * clearing it. No longer required because migration 3 unconditionally
49+ * clears it.
50+ * * Migration 2 used to ensure that the target_global row had a correct count
51+ * of targets. No longer required because migration 3 deletes them all.
52+ * * Migration 3 deletes the entire query cache to deal with cache corruption
53+ * related to limbo resolution. Addresses
54+ * https://github.com/firebase/firebase-ios-sdk/issues/1548.
4655 */
47- static FSTLevelDBSchemaVersion kSchemaVersion = 3 ;
48-
49- using firebase::firestore::local::LevelDbDocumentTargetKey;
50- using firebase::firestore::local::LevelDbQueryTargetKey;
51- using firebase::firestore::local::LevelDbTargetDocumentKey;
52- using firebase::firestore::local::LevelDbTargetGlobalKey;
53- using firebase::firestore::local::LevelDbTargetKey;
54- using firebase::firestore::local::LevelDbTransaction;
55- using firebase::firestore::local::LevelDbVersionKey;
56- using leveldb::Iterator;
57- using leveldb::Status;
58- using leveldb::Slice;
59- using leveldb::WriteOptions;
56+ const LevelDbMigrations::SchemaVersion kSchemaVersion = 3 ;
6057
6158/* *
62- * Save the given version number as the current version of the schema of the database.
59+ * Save the given version number as the current version of the schema of the
60+ * database.
6361 * @param version The version to save
6462 * @param transaction The transaction in which to save the new version number
6563 */
66- static void SaveVersion (FSTLevelDBSchemaVersion version, LevelDbTransaction *transaction) {
64+ void SaveVersion (LevelDbMigrations::SchemaVersion version,
65+ LevelDbTransaction* transaction) {
6766 std::string key = LevelDbVersionKey::Key ();
6867 std::string version_string = std::to_string (version);
6968 transaction->Put (key, version_string);
7069}
7170
72- static void DeleteEverythingWithPrefix (const std::string & prefix, leveldb::DB * db) {
71+ void DeleteEverythingWithPrefix (const std::string& prefix, leveldb::DB* db) {
7372 bool more_deletes = true ;
7473 while (more_deletes) {
7574 LevelDbTransaction transaction (db, " Delete everything with prefix"
7675 auto it = transaction.NewIterator ();
7776
7877 more_deletes = false ;
79- for (it->Seek (prefix); it->Valid () && absl::StartsWith (it->key (), prefix); it->Next ()) {
78+ for (it->Seek (prefix); it->Valid () && absl::StartsWith (it->key (), prefix);
79+ it->Next ()) {
8080 if (transaction.changed_keys () >= 1000 ) {
8181 more_deletes = true ;
8282 break ;
@@ -89,7 +89,7 @@ static void DeleteEverythingWithPrefix(const std::string &prefix, leveldb::DB *d
8989}
9090
9191/* * Migration 3. */
92- static void ClearQueryCache (leveldb::DB * db) {
92+ void ClearQueryCache (leveldb::DB* db) {
9393 DeleteEverythingWithPrefix (LevelDbTargetKey::KeyPrefix (), db);
9494 DeleteEverythingWithPrefix (LevelDbDocumentTargetKey::KeyPrefix (), db);
9595 DeleteEverythingWithPrefix (LevelDbTargetDocumentKey::KeyPrefix (), db);
@@ -98,16 +98,22 @@ static void ClearQueryCache(leveldb::DB *db) {
9898 LevelDbTransaction transaction (db, " Drop query cache"
9999
100100 // Reset the target global entry too (to reset the target count).
101- transaction.Put (LevelDbTargetGlobalKey::Key (), [FSTPBTargetGlobal message ]);
101+ firestore_client_TargetGlobal target_global{};
102+
103+ std::string bytes;
104+ Writer writer = Writer::Wrap (&bytes);
105+ writer.WriteNanopbMessage (firestore_client_TargetGlobal_fields,
106+ &target_global);
107+ transaction.Put (LevelDbTargetGlobalKey::Key (), std::move (bytes));
102108
103109 SaveVersion (3 , &transaction);
104110 transaction.Commit ();
105111}
106112
107- @implementation FSTLevelDBMigrations
113+ } // namespace
108114
109- + (FSTLevelDBSchemaVersion) schemaVersionWithTransaction :
110- (firebase::firestore::local:: LevelDbTransaction *) transaction {
115+ LevelDbMigrations::SchemaVersion LevelDbMigrations::ReadSchemaVersion (
116+ LevelDbTransaction* transaction) {
111117 std::string key = LevelDbVersionKey::Key ();
112118 std::string version_string;
113119 Status status = transaction->Get (key, &version_string);
@@ -118,22 +124,23 @@ + (FSTLevelDBSchemaVersion)schemaVersionWithTransaction:
118124 }
119125}
120126
121- + ( void ) runMigrationsWithDatabase : (leveldb::DB *) database {
122- [ self runMigrationsWithDatabase: database upToVersion: kSchemaVersion ] ;
127+ void LevelDbMigrations::RunMigrations (leveldb::DB* db) {
128+ RunMigrations (db, kSchemaVersion ) ;
123129}
124130
125- + ( void ) runMigrationsWithDatabase : (leveldb::DB *) database
126- upToVersion : (FSTLevelDBSchemaVersion) toVersion {
127- LevelDbTransaction transaction{database , " Read schema version"
128- FSTLevelDBSchemaVersion fromVersion = [ self schemaVersionWithTransaction: &transaction] ;
131+ void LevelDbMigrations::RunMigrations (leveldb::DB* db,
132+ SchemaVersion to_version) {
133+ LevelDbTransaction transaction{db , " Read schema version"
134+ SchemaVersion from_version = ReadSchemaVersion ( &transaction) ;
129135
130- // This must run unconditionally because schema migrations were added to iOS after the first
131- // release. There may be clients that have never run any migrations that have existing targets.
132- if (fromVersion < 3 && toVersion >= 3 ) {
133- ClearQueryCache (database);
136+ // This must run unconditionally because schema migrations were added to iOS
137+ // after the first release. There may be clients that have never run any
138+ // migrations that have existing targets.
139+ if (from_version < 3 && to_version >= 3 ) {
140+ ClearQueryCache (db);
134141 }
135142}
136143
137- @end
138-
139- NS_ASSUME_NONNULL_END
144+ } // namespace local
145+ } // namespace firestore
146+ } // namespace firebase
0 commit comments