Skip to content

Commit ae6c857

Browse files
authored
Move -Wreorder to cxxflag (instead of common, which impacts cflags) (#1881)
-Wreorder is not a valid cflag on at least linux/gcc.
1 parent 4736e05 commit ae6c857

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

cmake/compiler_setup.cmake

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,6 @@ if(CXX_CLANG OR CXX_GNU)
3737
-Wuninitialized
3838
-fno-common
3939

40-
-Wreorder -Werror=reorder
41-
4240
# Delete unused things
4341
-Wunused-function -Wunused-value -Wunused-variable
4442
)
@@ -49,6 +47,8 @@ if(CXX_CLANG OR CXX_GNU)
4947
# Cut down on symbol clutter
5048
# TODO(wilhuff) try -fvisibility=hidden
5149
-fvisibility-inlines-hidden
50+
51+
-Wreorder -Werror=reorder
5252
)
5353

5454
set(

0 commit comments

Comments
 (0)