Skip to content

Commit a50209c

Browse files
authored
Firestore Spec Tests: Port JS PR 7257 (use strings for targetPurpose) (#11191)
1 parent 36ac6fe commit a50209c

File tree

7 files changed

+172
-172
lines changed

7 files changed

+172
-172
lines changed

Firestore/Example/Tests/SpecTests/FSTSpecTests.mm

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -327,18 +327,18 @@ - (SnapshotVersion)parseVersion:(NSNumber *_Nullable)version {
327327
return Version(version.longLongValue);
328328
}
329329

330-
- (QueryPurpose)parseQueryPurpose:(NSNumber *)value {
331-
switch ([value intValue]) {
332-
case 0:
333-
return QueryPurpose::Listen;
334-
case 1:
335-
return QueryPurpose::ExistenceFilterMismatch;
336-
case 3:
337-
return QueryPurpose::LimboResolution;
338-
default:
339-
XCTFail(@"unknown query purpose value: %@", value);
340-
return QueryPurpose::Listen;
330+
- (QueryPurpose)parseQueryPurpose:(NSString *)value {
331+
if ([value isEqualToString:@"TargetPurposeListen"]) {
332+
return QueryPurpose::Listen;
341333
}
334+
if ([value isEqualToString:@"TargetPurposeExistenceFilterMismatch"]) {
335+
return QueryPurpose::ExistenceFilterMismatch;
336+
}
337+
if ([value isEqualToString:@"TargetPurposeLimboResolution"]) {
338+
return QueryPurpose::LimboResolution;
339+
}
340+
XCTFail(@"unknown query purpose value: %@", value);
341+
return QueryPurpose::Listen;
342342
}
343343

344344
- (DocumentViewChange)parseChange:(NSDictionary *)jsonDoc ofType:(DocumentViewChange::Type)type {

Firestore/Example/Tests/SpecTests/json/bundle_spec_test.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1179,7 +1179,7 @@
11791179
}
11801180
],
11811181
"resumeToken": "",
1182-
"targetPurpose": 3
1182+
"targetPurpose": "TargetPurposeLimboResolution"
11831183
},
11841184
"2": {
11851185
"queries": [

0 commit comments

Comments
 (0)