Skip to content

Commit 893e56a

Browse files
committed
Review feedback
Swift api limbo error message
1 parent d7b9e60 commit 893e56a

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

Firestore/Example/SwiftBuildTest/main.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -228,11 +228,11 @@ func readDocument(at docRef: DocumentReference) {
228228
func readDocumentWithOptions(at docRef: DocumentReference) {
229229
docRef.getDocument(options:GetOptions.defaultOptions()) { document, error in
230230
}
231-
docRef.getDocument(options:GetOptions.init(source:GetSource.default)) { document, error in
231+
docRef.getDocument(options:GetOptions(source:GetSource.default)) { document, error in
232232
}
233-
docRef.getDocument(options:GetOptions.init(source:GetSource.server)) { document, error in
233+
docRef.getDocument(options:GetOptions(source:.server)) { document, error in
234234
}
235-
docRef.getDocument(options:GetOptions.init(source:GetSource.cache)) { document, error in
235+
docRef.getDocument(options:GetOptions(source:GetSource.cache)) { document, error in
236236
}
237237
}
238238

Firestore/Source/Core/FSTFirestoreClient.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -298,7 +298,7 @@ - (void)getDocumentsFromLocalCache:(FIRQuery *)query
298298
FSTViewDocumentChanges *viewDocChanges = [view computeChangesWithDocuments:docs];
299299
FSTViewChange *viewChange = [view applyChangesToDocuments:viewDocChanges];
300300
FSTAssert(viewChange.limboChanges.count == 0,
301-
@"View returned limbo docs before target ack from the server.");
301+
@"View returned limbo documents during local-only query execution.");
302302

303303
FSTViewSnapshot *snapshot = viewChange.snapshot;
304304
FIRSnapshotMetadata *metadata =

0 commit comments

Comments
 (0)