Skip to content

Commit 722f71a

Browse files
authored
[In App Messaging] Address Xcode 14.3 Analyzer issues (#11242)
* [In App Messaging] Address Xcode 14.3 Analyzer issues * Review
1 parent 7453895 commit 722f71a

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

FirebaseInAppMessaging/Sources/Data/FIRIAMMessageContentDataWithImageURL.m

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
static NSInteger const SuccessHTTPStatusCode = 200;
2828

2929
@interface FIRIAMMessageContentDataWithImageURL ()
30-
@property(nonatomic, readwrite, nonnull, copy) NSString *titleText;
30+
@property(nonatomic, readwrite, nullable, copy) NSString *titleText;
3131
@property(nonatomic, readwrite, nonnull, copy) NSString *bodyText;
3232
@property(nonatomic, copy, nullable) NSString *actionButtonText;
3333
@property(nonatomic, copy, nullable) NSString *secondaryActionButtonText;
@@ -39,7 +39,7 @@ @interface FIRIAMMessageContentDataWithImageURL ()
3939
@end
4040

4141
@implementation FIRIAMMessageContentDataWithImageURL
42-
- (instancetype)initWithMessageTitle:(NSString *)title
42+
- (instancetype)initWithMessageTitle:(nullable NSString *)title
4343
messageBody:(NSString *)body
4444
actionButtonText:(nullable NSString *)actionButtonText
4545
secondaryActionButtonText:(nullable NSString *)secondaryActionButtonText

FirebaseInAppMessaging/Sources/Data/FIRIAMMessageDefinition.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
@implementation FIRIAMMessageRenderData
2323

2424
- (instancetype)initWithMessageID:(NSString *)messageID
25-
messageName:(NSString *)messageName
25+
messageName:(nullable NSString *)messageName
2626
contentData:(id<FIRIAMMessageContentData>)contentData
2727
renderingEffect:(FIRIAMRenderingEffectSetting *)renderEffect {
2828
if (self = [super init]) {

FirebaseInAppMessaging/Sources/Private/Data/FIRIAMMessageContentDataWithImageURL.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ NS_ASSUME_NONNULL_BEGIN
3737
* internally to perform the network request. Having it here so that
3838
* it's easier for doing mocking with unit testing.
3939
*/
40-
- (instancetype)initWithMessageTitle:(NSString *)title
40+
- (instancetype)initWithMessageTitle:(nullable NSString *)title
4141
messageBody:(NSString *)body
4242
actionButtonText:(nullable NSString *)actionButtonText
4343
secondaryActionButtonText:(nullable NSString *)secondaryActionButtonText

FirebaseInAppMessaging/Sources/Private/Data/FIRIAMMessageRenderData.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,11 +25,11 @@ NS_ASSUME_NONNULL_BEGIN
2525
@property(nonatomic, nonnull, readonly) id<FIRIAMMessageContentData> contentData;
2626
@property(nonatomic, nonnull, readonly) FIRIAMRenderingEffectSetting *renderingEffectSettings;
2727
@property(nonatomic, nonnull, copy, readonly) NSString *messageID;
28-
@property(nonatomic, nonnull, copy, readonly) NSString *name;
28+
@property(nonatomic, nullable, copy, readonly) NSString *name;
2929

3030
- (instancetype)init NS_UNAVAILABLE;
3131
- (instancetype)initWithMessageID:(NSString *)messageID
32-
messageName:(NSString *)messageName
32+
messageName:(nullable NSString *)messageName
3333
contentData:(id<FIRIAMMessageContentData>)contentData
3434
renderingEffect:(FIRIAMRenderingEffectSetting *)renderEffect;
3535
@end

0 commit comments

Comments
 (0)