merge master into googledatalogger branch (#2224)

* Clean up FIRAuth bits from FIRApp (#2110)

* Clean up FIRAuth bits from FIRApp

* Fix tvOS sample's Auth APIs. (#2158)

* Update CHANGELOG for Firestore v0.16.1 (#2164)

* Update the name of certificates bundle (#2171)

To accommodate for release 5.14.0.

* Fix format string in FSTRemoteStore error logging (#2172)

* C++: replace `FSTMaybeDocumentDictionary` with a C++ equivalent (#2139)

Also eliminate most usages of `FSTDocumentKey`, remove most methods from the Objective-C class and make it just a wrapper over `DocumentKey`. The only usage that cannot be directly replaced by C++ `DocumentKey` is in `FSTFieldValue`.

* Port performance optimizations to speed up reading large collections from Android (#2140)

Straightforward port of firebase/firebase-android-sdk#123.

* When searching for gRPC certificates, search the main bundle as well (#2183)

When the project is manually configured, it's possible that the certificates file gets added to the main bundle, not the Firestore framework bundle; make sure the bundle can be loaded in that case as well.

*  Fix Rome instructions (#2184)

* Use registerLibrary for pods in Firebase workspace (#2137)

* Add versioning to Functions and convert to FIRLibrary
* Convert Firestore to FIRLibrary
* Point travis to FirebaseCore pre-release for its deps
* Update user agent strings to match spec

* Port Memory remote document cache to C++ (#2176)

* Port Memory remote document cache to C++

* Minor tweaks to release note (#2182)

* Minor tweaks

* Update CHANGELOG.md

* Update CHANGELOG.md

* Port leveldb remote document cache to C++ (#2186)

* Port leveldb remote document cache

* Remove start from persistence interface (#2173)

* Remove start from persistence interface, switch FSTLevelDB to use a factory method that returns Status

* Fix small typos in public documentation. (#2192)

* fix the unit test #1451 (#2187)

* Port FSTRemoteDocumentCacheTest to use C++ interface (#2194)

* Release 5.15.0 (#2195)

* Update versions for Release 5.15.0

* Create 5.15.0.json

* Update CHANGELOG for Firestore v0.16.1 (#2164)

* Update the name of certificates bundle (#2171)

To accommodate for release 5.14.0.

* Fix format string in FSTRemoteStore error logging (#2172)

* Update CHANGELOG.md

* Update 5.15.0.json

* Port FSTRemoteDocumentCache (#2196)

* Remove FSTRemoteDocumentCache

* Fix leaks in Firestore (#2199)

* Clean up retain cycle in FSTLevelDB.

* Explicitly CFRelease our SCNetworkReachabilityRef.

* Make gRPC stream delegates weak

* Port DocumentState and UnknownDocument. (#2160)

Part of heldwriteacks.

Serialization work for this is largely deferred until after
nanopb-master is merged with master.

* Port FSTMemoryQueryCache to C++ (#2197)

* Port FSTLevelDBQueryCache to C++ (#2202)

* Port FSTLevelDBQueryCache to C++

* Fix Storage private imports. (#2206)

* Add missing Foundation imports to Interop headers (#2207)

* Migrate Firestore to the v1 protocol (#2200)

* Use python executable directly

  * python2 is not guaranteed to exist
  * scripts aren't directly executable on Windows

* Add Firestore v1 protos

* Point cmake at Firestore v1 protos

* Regenerate protobuf-related sources

* Make local protos refer to v1 protos

* fixup! Regenerate protobuf-related sources

* Remove v1beta1 protos

* s/v1beta1/v1/g in source.

* s/v1beta1/v1/ in the Xcode project

* Remove stale bug comments.

This was fixed by adding an explicit FieldPath API rather than exposing
escaping to the end user.

* Add SymbolCollisionTest comment for ARCore (#2210)

* Continue work on ReferenceSet (#2213)

* Migrate FSTDocumentReference to C++

* Change SortedSet template parameter ordering

Makes it easier to specify a comparator without specifying what the
empty member of the underlying map is.

* Migrate MemoryMutationQueue to C++ references by key

* migrate.py

* CMake

* Finish porting ReferenceSet

* Swap reference set implementation

* Port MemoryQueryCache to use ported ReferenceSet

* Port FSTReferenceSetTest

* Port usage for limbo document refs

* Port LRU and LocalStore usages

* Remove FSTReferenceSet and FSTDocumentReference

* Style

* Add newline

* Implement QueryCache interface and port QueryCache tests (#2209)

* Implement QueryCache interface and port tests

* Port production usages of QueryCache (#2211)

* Remove FSTQueryCache and implementations

* Switch size() to size_t

* Keep imports consistent (#2217)

* Fix private tests by removing unnecessary storyboard entries (#2218)

* Fix xcode 9 build of FDLBuilderTestAppObjC (#2219)

* Rework FieldMask to use a (ordered) set of FieldPaths (#2136)

Rather than a vector.

Port of firebase/firebase-android-sdk#137

* Travis to Xcode 10.1 and clang-format to 8.0.0 (tags/google/stable/2018-08-24) (#2222)

* Travis to Xcode 10.1
* Update to clang-format 8
* Update clang-format homebrew link
* Work around space in filename style.sh issue

Author: mikehaney24

.travis.yml

@@ -1,5 +1,5 @@
 os: osx
-osx_image: xcode10
+osx_image: xcode10.1
 language: objective-c
 cache:
   - bundler

Carthage.md

@@ -63,7 +63,7 @@ binary "https://dl.google.com/dl/firebase/ios/carthage/FirebaseStorageBinary.jso
     into the Xcode project and make sure they're added to the
     `Copy Bundle Resources` Build Phase :
     - For Firestore:
-        - ./Carthage/Build/iOS/FirebaseFirestore.framework/gRPCCertificates.bundle
+        - ./Carthage/Build/iOS/FirebaseFirestore.framework/gRPCCertificates-Firestore.bundle
     - For Invites:
         - ./Carthage/Build/iOS/FirebaseInvites.framework/GoogleSignIn.bundle
         - ./Carthage/Build/iOS/FirebaseInvites.framework/GPPACLPickerResources.bundle

Example/Auth/Tests/FIRAuthTests.m

@@ -21,7 +21,7 @@
 #import <FirebaseAuthInterop/FIRAuthInterop.h>
 #import <FirebaseCore/FIRAppInternal.h>
 #import <FirebaseCore/FIRComponent.h>
-#import <FirebaseCore/FIRComponentRegistrant.h>
+#import <FirebaseCore/FIRLibrary.h>
 
 #import "FIRAdditionalUserInfo.h"
 #import "FIRAuth_Internal.h"
@@ -225,7 +225,7 @@
 static const NSTimeInterval kWaitInterval = .5;
 
 /** Category for FIRAuth to expose FIRComponentRegistrant conformance. */
-@interface FIRAuth () <FIRComponentRegistrant>
+@interface FIRAuth () <FIRLibrary>
 @end
 
 /** @class FIRAuthTests
@@ -365,20 +365,6 @@ - (void)testLifeCycle {
   XCTAssertNil(auth);
 }
 
-/** @fn testGetUID
-    @brief Verifies that FIRApp's getUIDImplementation is correctly set by FIRAuth.
- */
-- (void)testGetUID {
-  // TODO: Remove this test once Firestore, Database, and Storage move over to the new Auth interop
-  //       library.
-  FIRApp *app = [FIRApp defaultApp];
-  XCTAssertNotNil(app.getUIDImplementation);
-  [[FIRAuth auth] signOut:NULL];
-  XCTAssertNil(app.getUIDImplementation());
-  [self waitForSignIn];
-  XCTAssertEqualObjects(app.getUIDImplementation(), kLocalID);
-}
-
 #pragma mark - Server API Tests
 
 /** @fn testFetchProvidersForEmailSuccess
@@ -2283,8 +2269,8 @@ - (void)mockSecureTokenResponseWithError:(nullable NSError *)error {
  */
 - (void)enableAutoTokenRefresh {
   XCTestExpectation *expectation = [self expectationWithDescription:@"autoTokenRefreshcallback"];
-  [[FIRAuth auth].app getTokenForcingRefresh:NO withCallback:^(NSString *_Nullable token,
-                                                                NSError *_Nullable error) {
+  [[FIRAuth auth] getTokenForcingRefresh:NO withCallback:^(NSString *_Nullable token,
+                                                           NSError *_Nullable error) {
     [expectation fulfill];
   }];
   [self waitForExpectationsWithTimeout:kExpectationTimeout handler:nil];

Example/Core/Tests/FIRAnalyticsConfigurationTest.m

@@ -99,19 +99,15 @@ - (void)testSettingAnalyticsCollectionEnabled {
   [self.observerMock setExpectationOrderMatters:YES];
   [[self.observerMock expect] notificationWithName:notificationName
                                             object:config
-                                          userInfo:@{
-                                            notificationName : @YES
-                                          }];
+                                          userInfo:@{notificationName : @YES}];
 
   // Test setting to enabled.
   [config setAnalyticsCollectionEnabled:YES];
 
   // Expect the second notification.
   [[self.observerMock expect] notificationWithName:notificationName
                                             object:config
-                                          userInfo:@{
-                                            notificationName : @NO
-                                          }];
+                                          userInfo:@{notificationName : @NO}];
 
   // Test setting to disabled.
   [config setAnalyticsCollectionEnabled:NO];

Example/Core/Tests/FIRAppTest.m

@@ -26,9 +26,26 @@ @interface FIRComponentContainer (TestInternal)
 @property(nonatomic, strong) NSMutableDictionary<NSString *, FIRComponentCreationBlock> *components;
 @property(nonatomic, strong) NSMutableDictionary<NSString *, id> *cachedInstances;
 
-+ (void)registerAsComponentRegistrant:(Class)klass inSet:(NSMutableSet<Class> *)allRegistrants;
-
++ (void)registerAsComponentRegistrant:(Class<FIRLibrary>)klass
+                                inSet:(NSMutableSet<Class> *)allRegistrants;
 - (instancetype)initWithApp:(FIRApp *)app registrants:(NSMutableSet<Class> *)allRegistrants;
+@end
+
+@interface FIRComponentContainer (TestInternalImplementations)
+- (instancetype)initWithApp:(FIRApp *)app
+                 components:(NSDictionary<NSString *, FIRComponentCreationBlock> *)components;
+@end
+
+@implementation FIRComponentContainer (TestInternalImplementations)
+
+- (instancetype)initWithApp:(FIRApp *)app
+                 components:(NSDictionary<NSString *, FIRComponentCreationBlock> *)components {
+  self = [self initWithApp:app registrants:[[NSMutableSet alloc] init]];
+  if (self) {
+    self.components = [components mutableCopy];
+  }
+  return self;
+}
 
 @end
 
@@ -47,13 +64,6 @@ - (void)testRegisteringConformingClass {
   XCTAssertTrue([allRegistrants containsObject:testClass]);
 }
 
-- (void)testRegisteringNonConformingClass {
-  NSMutableSet<Class> *allRegistrants = [NSMutableSet<Class> set];
-  XCTAssertThrows(
-      [FIRComponentContainer registerAsComponentRegistrant:[NSString class] inSet:allRegistrants]);
-  XCTAssertTrue(allRegistrants.count == 0);
-}
-
 - (void)testComponentsPopulatedOnInit {
   FIRComponentContainer *container = [self containerWithRegistrants:@ [[FIRTestClass class]]];
 
@@ -149,7 +159,6 @@ - (FIRComponentContainer *)containerWithRegistrants:(NSArray<Class> *)registrant
   for (Class c in registrants) {
     [FIRComponentContainer registerAsComponentRegistrant:c inSet:allRegistrants];
   }
-
   return [[FIRComponentContainer alloc] initWithApp:appMock registrants:allRegistrants];
 }
 

Example/Core/Tests/FIRComponentContainerTest.m

@@ -82,8 +82,8 @@ - (void)testDefaultOptions {
 }
 
 - (void)testInitCustomizedOptions {
-  FIROptions *options =
-      [[FIROptions alloc] initWithGoogleAppID:kGoogleAppID GCMSenderID:kGCMSenderID];
+  FIROptions *options = [[FIROptions alloc] initWithGoogleAppID:kGoogleAppID
+                                                    GCMSenderID:kGCMSenderID];
   options.APIKey = kAPIKey;
   options.bundleID = kBundleID;
   options.clientID = kClientID;
@@ -98,8 +98,8 @@ - (void)testInitCustomizedOptions {
 }
 
 - (void)testInitWithContentsOfFile {
-  NSString *filePath =
-      [[NSBundle mainBundle] pathForResource:@"GoogleService-Info" ofType:@"plist"];
+  NSString *filePath = [[NSBundle mainBundle] pathForResource:@"GoogleService-Info"
+                                                       ofType:@"plist"];
   FIROptions *options = [[FIROptions alloc] initWithContentsOfFile:filePath];
   [self assertOptionsMatchDefaults:options andProjectID:YES];
   XCTAssertNil(options.deepLinkURLScheme);
@@ -136,8 +136,8 @@ - (void)assertOptionsMatchDefaults:(FIROptions *)options andProjectID:(BOOL)matc
 
 - (void)testCopyingProperties {
   NSMutableString *mutableString;
-  FIROptions *options =
-      [[FIROptions alloc] initWithGoogleAppID:kGoogleAppID GCMSenderID:kGCMSenderID];
+  FIROptions *options = [[FIROptions alloc] initWithGoogleAppID:kGoogleAppID
+                                                    GCMSenderID:kGCMSenderID];
   mutableString = [[NSMutableString alloc] initWithString:@"1"];
   options.APIKey = mutableString;
   [mutableString appendString:@"2"];
@@ -208,8 +208,8 @@ - (void)testCopyWithZone {
   XCTAssertEqualObjects(newOptions.deepLinkURLScheme, kDeepLinkURLScheme);
 
   // customized options
-  FIROptions *customizedOptions =
-      [[FIROptions alloc] initWithGoogleAppID:kGoogleAppID GCMSenderID:kGCMSenderID];
+  FIROptions *customizedOptions = [[FIROptions alloc] initWithGoogleAppID:kGoogleAppID
+                                                              GCMSenderID:kGCMSenderID];
   customizedOptions.deepLinkURLScheme = kDeepLinkURLScheme;
   FIROptions *copyCustomizedOptions = [customizedOptions copy];
   [copyCustomizedOptions setDeepLinkURLScheme:kNewDeepLinkURLScheme];
@@ -466,20 +466,16 @@ - (void)testAnalyticsCollectionGlobalSwitchOverrideToDisable {
   OCMStub([appMock isDataCollectionDefaultEnabled]).andReturn(YES);
 
   // Test the three Analytics flags that override to disable Analytics collection.
-  FIROptions *collectionEnabledOptions = [[FIROptions alloc] initInternalWithOptionsDictionary:@{
-    kFIRIsAnalyticsCollectionEnabled : @NO
-  }];
+  FIROptions *collectionEnabledOptions = [[FIROptions alloc]
+      initInternalWithOptionsDictionary:@{kFIRIsAnalyticsCollectionEnabled : @NO}];
   XCTAssertFalse(collectionEnabledOptions.isAnalyticsCollectionEnabled);
 
-  FIROptions *collectionDeactivatedOptions =
-      [[FIROptions alloc] initInternalWithOptionsDictionary:@{
-        kFIRIsAnalyticsCollectionDeactivated : @YES
-      }];
+  FIROptions *collectionDeactivatedOptions = [[FIROptions alloc]
+      initInternalWithOptionsDictionary:@{kFIRIsAnalyticsCollectionDeactivated : @YES}];
   XCTAssertFalse(collectionDeactivatedOptions.isAnalyticsCollectionEnabled);
 
-  FIROptions *measurementEnabledOptions = [[FIROptions alloc] initInternalWithOptionsDictionary:@{
-    kFIRIsMeasurementEnabled : @NO
-  }];
+  FIROptions *measurementEnabledOptions =
+      [[FIROptions alloc] initInternalWithOptionsDictionary:@{kFIRIsMeasurementEnabled : @NO}];
   XCTAssertFalse(measurementEnabledOptions.isAnalyticsCollectionEnabled);
 }
 
@@ -491,14 +487,12 @@ - (void)testAnalyticsCollectionGlobalSwitchOverrideToEnable {
   OCMStub([appMock isDataCollectionDefaultEnabled]).andReturn(NO);
 
   // Test the two Analytics flags that can override and enable collection.
-  FIROptions *collectionEnabledOptions = [[FIROptions alloc] initInternalWithOptionsDictionary:@{
-    kFIRIsAnalyticsCollectionEnabled : @YES
-  }];
+  FIROptions *collectionEnabledOptions = [[FIROptions alloc]
+      initInternalWithOptionsDictionary:@{kFIRIsAnalyticsCollectionEnabled : @YES}];
   XCTAssertTrue(collectionEnabledOptions.isAnalyticsCollectionEnabled);
 
-  FIROptions *measurementEnabledOptions = [[FIROptions alloc] initInternalWithOptionsDictionary:@{
-    kFIRIsMeasurementEnabled : @YES
-  }];
+  FIROptions *measurementEnabledOptions =
+      [[FIROptions alloc] initInternalWithOptionsDictionary:@{kFIRIsMeasurementEnabled : @YES}];
   XCTAssertTrue(measurementEnabledOptions.isAnalyticsCollectionEnabled);
 }
 
@@ -534,31 +528,27 @@ - (void)testAnalyticsCollectionExplicitlySet {
 
   // Test the old measurement flag.
   options = [[FIROptions alloc] initInternalWithOptionsDictionary:@{}];
-  analyticsOptions = [options analyticsOptionsDictionaryWithInfoDictionary:@{
-    kFIRIsMeasurementEnabled : @YES
-  }];
+  analyticsOptions =
+      [options analyticsOptionsDictionaryWithInfoDictionary:@{kFIRIsMeasurementEnabled : @YES}];
   XCTAssertTrue([options isAnalyticsCollectionExpicitlySet]);
 
   options = [[FIROptions alloc] initInternalWithOptionsDictionary:@{}];
-  analyticsOptions = [options analyticsOptionsDictionaryWithInfoDictionary:@{
-    kFIRIsMeasurementEnabled : @NO
-  }];
+  analyticsOptions =
+      [options analyticsOptionsDictionaryWithInfoDictionary:@{kFIRIsMeasurementEnabled : @NO}];
   XCTAssertTrue([options isAnalyticsCollectionExpicitlySet]);
 
   // For good measure, a combination of all 3 (even if they conflict).
   optionsDictionary =
-      @{kFIRIsAnalyticsCollectionDeactivated : @YES,
-        kFIRIsAnalyticsCollectionEnabled : @YES};
+      @{kFIRIsAnalyticsCollectionDeactivated : @YES, kFIRIsAnalyticsCollectionEnabled : @YES};
   options = [[FIROptions alloc] initInternalWithOptionsDictionary:optionsDictionary];
-  analyticsOptions = [options analyticsOptionsDictionaryWithInfoDictionary:@{
-    kFIRIsMeasurementEnabled : @NO
-  }];
+  analyticsOptions =
+      [options analyticsOptionsDictionaryWithInfoDictionary:@{kFIRIsMeasurementEnabled : @NO}];
   XCTAssertTrue([options isAnalyticsCollectionExpicitlySet]);
 }
 
 - (void)testModifyingOptionsThrows {
-  FIROptions *options =
-      [[FIROptions alloc] initWithGoogleAppID:kGoogleAppID GCMSenderID:kGCMSenderID];
+  FIROptions *options = [[FIROptions alloc] initWithGoogleAppID:kGoogleAppID
+                                                    GCMSenderID:kGCMSenderID];
   options.editingLocked = YES;
 
   // Modification to every property should result in an exception.

Example/Core/Tests/FIROptionsTest.m

@@ -16,7 +16,7 @@
 
 #import <FirebaseCore/FIRComponent.h>
 #import <FirebaseCore/FIRComponentContainer.h>
-#import <FirebaseCore/FIRComponentRegistrant.h>
+#import <FirebaseCore/FIRLibrary.h>
 
 @protocol FIRComponentRegistrant;
 
@@ -28,13 +28,12 @@
 @end
 
 /// A test class that is a component registrant.
-@interface FIRTestClass
-    : NSObject <FIRTestProtocol, FIRComponentRegistrant, FIRComponentLifecycleMaintainer>
+@interface FIRTestClass : NSObject <FIRTestProtocol, FIRComponentLifecycleMaintainer, FIRLibrary>
 @end
 
 /// A test class that is a component registrant, a duplicate of FIRTestClass.
 @interface FIRTestClassDuplicate
-    : NSObject <FIRTestProtocol, FIRComponentRegistrant, FIRComponentLifecycleMaintainer>
+    : NSObject <FIRTestProtocol, FIRComponentLifecycleMaintainer, FIRLibrary>
 @end
 
 #pragma mark - Eager Component
@@ -47,7 +46,7 @@
 /// A test class that is a component registrant that provides a component requiring eager
 /// instantiation, and is cached for easier validation that it was instantiated.
 @interface FIRTestClassEagerCached
-    : NSObject <FIRTestProtocolEagerCached, FIRComponentRegistrant, FIRComponentLifecycleMaintainer>
+    : NSObject <FIRTestProtocol, FIRComponentLifecycleMaintainer, FIRLibrary>
 @end
 
 #pragma mark - Cached Component
@@ -59,5 +58,5 @@
 /// A test class that is a component registrant that provides a component that requests to be
 /// cached.
 @interface FIRTestClassCached
-    : NSObject <FIRTestProtocolCached, FIRComponentRegistrant, FIRComponentLifecycleMaintainer>
+    : NSObject <FIRTestProtocol, FIRComponentLifecycleMaintainer, FIRLibrary>
 @end

Example/Core/Tests/FIRTestComponents.h

@@ -47,7 +47,7 @@ @implementation FIRTestClassDuplicate
 - (void)doSomething {
 }
 
-/// FIRComponentRegistrant conformance.
+/// FIRLibrary conformance.
 + (nonnull NSArray<FIRComponent *> *)componentsToRegister {
   FIRComponent *testComponent =
       [FIRComponent componentWithProtocol:@protocol(FIRTestProtocol)
@@ -72,7 +72,7 @@ @implementation FIRTestClassEagerCached
 - (void)doSomethingFaster {
 }
 
-/// FIRComponentRegistrant conformance.
+/// FIRLibrary conformance.
 + (nonnull NSArray<FIRComponent *> *)componentsToRegister {
   FIRComponent *testComponent = [FIRComponent
       componentWithProtocol:@protocol(FIRTestProtocolEagerCached)
@@ -92,13 +92,16 @@ - (void)doSomethingFaster {
 - (void)appWillBeDeleted:(FIRApp *)app {
 }
 
+- (void)doSomething {
+}
+
 @end
 
 #pragma mark - Cached Component
 
 @implementation FIRTestClassCached
 
-/// FIRComponentRegistrant conformance.
+/// FIRLibrary conformance.
 + (nonnull NSArray<FIRComponent *> *)componentsToRegister {
   FIRComponent *testComponent = [FIRComponent
       componentWithProtocol:@protocol(FIRTestProtocolCached)
@@ -115,4 +118,7 @@ @implementation FIRTestClassCached
 - (void)appWillBeDeleted:(FIRApp *)app {
 }
 
+- (void)doSomething {
+}
+
 @end

Example/Core/Tests/FIRTestComponents.m

@@ -39,6 +39,27 @@ @interface FIRDatabaseComponent (Internal)
 - (instancetype)initWithApp:(FIRApp *)app;
 @end
 
+@interface FIRComponentContainer (TestInternal)
+@property(nonatomic, strong) NSMutableDictionary<NSString *, FIRComponentCreationBlock> *components;
+@end
+
+@interface FIRComponentContainer (TestInternalImplementations)
+- (instancetype)initWithApp:(FIRApp *)app
+                 components:(NSDictionary<NSString *, FIRComponentCreationBlock> *)components;
+@end
+
+@implementation FIRComponentContainer (TestInternalImplementations)
+
+- (instancetype)initWithApp:(FIRApp *)app
+                 components:(NSDictionary<NSString *, FIRComponentCreationBlock> *)components {
+  self = [self initWithApp:app registrants:[[NSMutableSet alloc] init]];
+  if (self) {
+    self.components = [components mutableCopy];
+  }
+  return self;
+}
+@end
+
 @implementation FIRFakeApp
 
 - (instancetype)initWithName:(NSString *)name URL:(NSString *)url {

Example/Database/Tests/Helpers/FIRFakeApp.m

@@ -29,10 +29,6 @@
 		<key>NSAllowsArbitraryLoads</key>
 		<true/>
 	</dict>
-	<key>UILaunchStoryboardName</key>
-	<string>LaunchScreen</string>
-	<key>UIMainStoryboardFile</key>
-	<string>Main</string>
 	<key>UIRequiredDeviceCapabilities</key>
 	<array>
 		<string>armv7</string>