Skip to content

Commit 3e7aa39

Browse files
authored
[Firestore] Improve logging in scripts/check_firestore_symbols.sh (#12535)
1 parent 370385c commit 3e7aa39

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

scripts/check_firestore_symbols.sh

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,14 +153,17 @@ nm ~/Library/Developer/Xcode/DerivedData/TestPkg-ObjC/Build/Products/Debug/TestP
153153
# return exit code 1, which will cause the set pipefail to terminate execution.
154154
# To avoid this, `|| true` ensures the exit code always indicates success.
155155
DIFF=$(
156-
git diff --no-index \
156+
git diff --no-index --output-indicator-new="?" \
157157
objc_symbols_without_linker_flag.txt \
158158
objc_symbols_with_linker_flag.txt \
159159
|| true
160160
)
161161
if [[ -n "$DIFF" ]]; then
162162
echo "Failure: Unlinked Objective-C symbols have been detected:"
163163
echo "$DIFF"
164+
echo -n "💡 To fix, follow the process shown in "
165+
echo -n "https://github.com/firebase/firebase-ios-sdk/pull/12534 for the "
166+
echo "above symbols that are prefixed with ?"
164167
exit 1
165168
else
166169
echo "Success: No unlinked Objective-C symbols have been detected."

0 commit comments

Comments
 (0)