Checking strongSelf

schmidt-sebastian · schmidt-sebastian · commit 3e1143a36347 · 2018-10-22T16:17:59.000-07:00
diff --git a/Firebase/Storage/FIRStorageDownloadTask.m b/Firebase/Storage/FIRStorageDownloadTask.m
@@ -74,8 +74,8 @@ - (void)enqueueWithData:(nullable NSData *)resumeData {
     }
 
     [fetcher setResumeDataBlock:^(NSData *data) {
-      if (data) {
-        FIRStorageDownloadTask *strong = weakSelf;
+      FIRStorageDownloadTask *strong = weakSelf;
+      if (strong && data) {
         strong->_downloadData = data;
       }
     }];

Original file line number	Diff line number	Diff line change
`@@ -74,8 +74,8 @@ - (void)enqueueWithData:(nullable NSData *)resumeData {`
`74`	`74`	`}`
`75`	`75`
`76`	`76`	`[fetcher setResumeDataBlock:^(NSData *data) {`
`77`		`- if (data) {`
`78`		`- FIRStorageDownloadTask *strong = weakSelf;`
	`77`	`+ FIRStorageDownloadTask *strong = weakSelf;`
	`78`	`+ if (strong && data) {`
`79`	`79`	`strong->_downloadData = data;`
`80`	`80`	`}`
`81`	`81`	`}];`