Skip to content

Commit 2f97224

Browse files
authored
Fix GoogleAppMeasurement SPM CI (#8606)
1 parent a9caa29 commit 2f97224

File tree

4 files changed

+15
-31
lines changed

4 files changed

+15
-31
lines changed

Package.swift

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -147,9 +147,9 @@ let package = Package(
147147
.package(
148148
name: "GoogleAppMeasurement",
149149
url: "https://github.com/google/GoogleAppMeasurement.git",
150-
// Please keep the version specification aligned with
151-
// scripts/setup_spm_test_app_measurement.sh.
152-
.exact("8.3.1")
150+
// Note that CI changes the version to the head of main for CI.
151+
// See scripts/setup_spm_tests.sh.
152+
.exact("8.7.0")
153153
),
154154
.package(
155155
name: "GoogleDataTransport",
@@ -302,8 +302,8 @@ let package = Package(
302302
),
303303
.binaryTarget(
304304
name: "FirebaseAnalytics",
305-
url: "https://dl.google.com/firebase/ios/swiftpm/8.3.0/FirebaseAnalytics.zip",
306-
checksum: "3225b785ef2884889b41216150d000ccac3aa9d5e9bebbd993a63725503949e5"
305+
url: "https://dl.google.com/firebase/ios/swiftpm/8.7.0/FirebaseAnalytics.zip",
306+
checksum: "063f03bc6d6bd1efbd3057a64977aef3e6fac4e0a761fc30af1acd554212164c"
307307
),
308308
.target(
309309
name: "FirebaseAnalyticsSwiftTarget",

scripts/build.sh

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -648,7 +648,6 @@ case "$product-$platform-$method" in
648648

649649
# Note that the combine tests require setting the minimum iOS and tvOS version to 13.0
650650
*-*-spm)
651-
"${scripts_dir}/setup_spm_test_app_measurement.sh"
652651
RunXcodebuild \
653652
-scheme $product \
654653
"${xcb_flags[@]}" \
@@ -658,7 +657,6 @@ case "$product-$platform-$method" in
658657
;;
659658

660659
*-*-spmbuildonly)
661-
"${scripts_dir}/setup_spm_test_app_measurement.sh"
662660
RunXcodebuild \
663661
-scheme $product \
664662
"${xcb_flags[@]}" \

scripts/setup_spm_test_app_measurement.sh

Lines changed: 0 additions & 24 deletions
This file was deleted.

scripts/setup_spm_tests.sh

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,16 @@
1414
# See the License for the specific language governing permissions and
1515
# limitations under the License.
1616

17+
18+
# Point SPM CI to the tip of main of https://github.com/google/GoogleAppMeasurement
19+
# so that the release process can defer publish the GoogleAppMeasurement tag
20+
# until after testing.
21+
22+
# For example: Change `.exact("8.3.1")` to `.branch("main")`
23+
24+
sed -i '' 's#exact("[0-9.]*#branch("main#' Package.swift
25+
26+
1727
# Move schemes into place to run Swift Package Manager tests
1828
# These cannot be stored in the correct location because they cause
1929
# clutter for SDK clients.

0 commit comments

Comments
 (0)