GULLogger: ignore a data race (#1959)

var-const · web-flow · commit 1eed3ee4833d · 2018-10-17T12:51:27.000-04:00
Thread sanitizer spots a data race in `GULSetLoggerLevel`. Following #1390, annotate the function so that TSan will ignore it.
diff --git a/GoogleUtilities/Logger/GULLogger.m b/GoogleUtilities/Logger/GULLogger.m
@@ -90,7 +90,7 @@ void GULLoggerForceDebug(void) {
   }
 }
 
-void GULSetLoggerLevel(GULLoggerLevel loggerLevel) {
+__attribute__((no_sanitize("thread"))) void GULSetLoggerLevel(GULLoggerLevel loggerLevel) {
   if (loggerLevel < GULLoggerLevelMin || loggerLevel > GULLoggerLevelMax) {
     GULLogError(kGULLoggerLogger, NO, @"I-COR000023", @"Invalid logger level, %ld",
                 (long)loggerLevel);

Original file line number	Diff line number	Diff line change
`@@ -90,7 +90,7 @@ void GULLoggerForceDebug(void) {`
`90`	`90`	`}`
`91`	`91`	`}`
`92`	`92`
`93`		`-void GULSetLoggerLevel(GULLoggerLevel loggerLevel) {`
	`93`	`+__attribute__((no_sanitize("thread"))) void GULSetLoggerLevel(GULLoggerLevel loggerLevel) {`
`94`	`94`	`if (loggerLevel < GULLoggerLevelMin \|\| loggerLevel > GULLoggerLevelMax) {`
`95`	`95`	`GULLogError(kGULLoggerLogger, NO, @"I-COR000023", @"Invalid logger level, %ld",`
`96`	`96`	`(long)loggerLevel);`