Skip to content

Commit 1a857fe

Browse files
authored
Don't save library version to NSUserDefaults (#212)
This seems to be a holdover from some old code, and it's not being used anywhere in the component. Plus it's better not to be saving anything in `[NSUserDefaults standardUserDefaults]` as that is the developer/app's domain. Also renamed the messaging code while I was in there to be something meaningful ("000" → "PrintLibraryVersion").
1 parent 768c405 commit 1a857fe

File tree

4 files changed

+6
-14
lines changed

4 files changed

+6
-14
lines changed

Firebase/Messaging/FIRMMessageCode.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ typedef NS_ENUM(NSInteger, FIRMessagingMessageCode) {
2121
kFIRMessagingMessageCodeFIRApp000 = 1000, // I-FCM001000
2222
kFIRMessagingMessageCodeFIRApp001 = 1001, // I-FCM001001
2323
// FIRMessaging.m
24-
kFIRMessagingMessageCodeMessaging000 = 2000, // I-FCM002000
24+
kFIRMessagingMessageCodeMessagingPrintLibraryVersion = 2000, // I-FCM002000
2525
kFIRMessagingMessageCodeMessaging001 = 2001, // I-FCM002001
2626
kFIRMessagingMessageCodeMessaging002 = 2002, // I-FCM002002 - no longer used
2727
kFIRMessagingMessageCodeMessaging003 = 2003, // I-FCM002003

Firebase/Messaging/FIRMessaging.m

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -187,8 +187,12 @@ - (void)setRemoteMessageDelegate:(id<FIRMessagingDelegate>)delegate {
187187
#pragma mark - Config
188188

189189
- (void)start {
190+
// Print the library version for logging.
191+
NSString *currentLibraryVersion = FIRMessagingCurrentLibraryVersion();
192+
FIRMessagingLoggerInfo(kFIRMessagingMessageCodeMessagingPrintLibraryVersion,
193+
@"FIRMessaging library version %@",
194+
currentLibraryVersion);
190195

191-
[self saveLibraryVersion];
192196
[self setupReceiver];
193197

194198
NSString *hostname = kFIRMessagingReachabilityHostname;
@@ -244,14 +248,6 @@ - (void)setupNotificationListeners {
244248
object:nil];
245249
}
246250

247-
- (void)saveLibraryVersion {
248-
NSString *currentLibraryVersion = FIRMessagingCurrentLibraryVersion();
249-
[[NSUserDefaults standardUserDefaults] setObject:currentLibraryVersion
250-
forKey:kFIRMessagingLibraryVersion];
251-
FIRMessagingLoggerInfo(kFIRMessagingMessageCodeMessaging000, @"FIRMessaging library version %@",
252-
currentLibraryVersion);
253-
}
254-
255251
- (void)setupReceiver {
256252
self.receiver = [[FIRMessagingReceiver alloc] init];
257253
self.receiver.delegate = self;

Firebase/Messaging/FIRMessagingConstants.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,6 @@ FOUNDATION_EXPORT NSString *const kFIRMessagingMessageSyncViaMCSKey;
4242
FOUNDATION_EXPORT NSString *const kFIRMessagingMessageSyncMessageTTLKey;
4343
FOUNDATION_EXPORT NSString *const kFIRMessagingMessageLinkKey;
4444

45-
FOUNDATION_EXPORT NSString *const kFIRMessagingLibraryVersion;
46-
4745
FOUNDATION_EXPORT NSString *const kFIRMessagingRemoteNotificationsProxyEnabledInfoPlistKey;
4846

4947
FOUNDATION_EXPORT NSString *const kFIRMessagingApplicationSupportSubDirectory;

Firebase/Messaging/FIRMessagingConstants.m

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,6 @@
3535
NSString *const kFIRMessagingMessageSyncMessageTTLKey = @"gcm." @"ttl";
3636
NSString *const kFIRMessagingMessageLinkKey = @"gcm." @"app_link";
3737

38-
NSString *const kFIRMessagingLibraryVersion = @"FIRMessaging-version";
39-
4038
NSString *const kFIRMessagingRemoteNotificationsProxyEnabledInfoPlistKey =
4139
@"FirebaseAppDelegateProxyEnabled";
4240

0 commit comments

Comments
 (0)