Skip to content

Commit 19d1bb3

Browse files
Adding NS_SWIFT_NAME for FIRListenerRegistration (#339)
1 parent 202fac5 commit 19d1bb3

File tree

4 files changed

+9
-6
lines changed

4 files changed

+9
-6
lines changed

Firestore/CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# Unreleased
2-
- [fixed] Add an NS_SWIFT_NAME for FIRSnapshotMetadata
2+
- [fixed] Add an NS_SWIFT_NAME for FIRSnapshotMetadata and FIRListenerRegistration
33

44
# 2017-10-03 -- v0.8.0
55
- Initial public release.

Firestore/Example/SwiftBuildTest/main.swift

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -274,10 +274,6 @@ func transactions() {
274274
}
275275

276276
func types() {
277-
// Just highlighting the types of everything, though devs can/will often omit them.
278-
// This list comes from:
279-
//
280-
// grep -r ^FIR_SWIFT_NAME Firestore/Source/Public | sed 's/.*(/let _: /; s/)/;/'
281277
let _: CollectionReference;
282278
let _: DocumentChange;
283279
let _: DocumentListenOptions;
@@ -288,9 +284,11 @@ func types() {
288284
let _: Firestore;
289285
let _: FirestoreSettings;
290286
let _: GeoPoint;
287+
let _: ListenerRegistration;
291288
let _: QueryListenOptions;
292289
let _: Query;
293290
let _: QuerySnapshot;
291+
let _: SetOptions;
294292
let _: SnapshotMetadata;
295293
let _: Transaction;
296294
let _: WriteBatch;

Firestore/Source/Public/FIRListenerRegistration.h

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,12 @@
1616

1717
#import <Foundation/Foundation.h>
1818

19+
#import "FIRFirestoreSwiftNameSupport.h"
20+
1921
NS_ASSUME_NONNULL_BEGIN
2022

2123
/** Represents a listener that can be removed by calling remove. */
24+
FIR_SWIFT_NAME(ListenerRegistration)
2225
@protocol FIRListenerRegistration <NSObject>
2326

2427
/**

Firestore/Source/Public/FIRSetOptions.h

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@
1616

1717
#import <Foundation/Foundation.h>
1818

19+
#import "FIRFirestoreSwiftNameSupport.h"
20+
1921
NS_ASSUME_NONNULL_BEGIN
2022

2123
/**
@@ -24,7 +26,7 @@ NS_ASSUME_NONNULL_BEGIN
2426
* `FIRWriteBatch` and `FIRTransaction` can be configured to perform granular merges instead
2527
* of overwriting the target documents in their entirety.
2628
*/
27-
NS_SWIFT_NAME(SetOptions)
29+
FIR_SWIFT_NAME(SetOptions)
2830
@interface FIRSetOptions : NSObject
2931

3032
/** */

0 commit comments

Comments
 (0)