Fix analyze of FirebaseFunctions (#1742)

Author: paulb777

Functions/FirebaseFunctions/FUNError.h

@@ -29,6 +29,8 @@ NS_ASSUME_NONNULL_BEGIN
  * @param serializer A serializer to use to decode the details in the error response.
  * @return The corresponding error.
  */
-NSError *FUNErrorForResponse(NSInteger status, NSData *_Nullable body, FUNSerializer *serializer);
+NSError *_Nullable FUNErrorForResponse(NSInteger status,
+                                       NSData *_Nullable body,
+                                       FUNSerializer *serializer);
 
 NS_ASSUME_NONNULL_END

Functions/FirebaseFunctions/FUNError.m

@@ -90,7 +90,7 @@ FIRFunctionsErrorCode FIRFunctionsErrorCodeForName(NSString *name) {
     };
   });
   NSNumber *code = errors[name];
-  if (code) {
+  if (code != nil) {
     return code.intValue;
   }
   return FIRFunctionsErrorCodeInternal;
@@ -141,7 +141,9 @@ FIRFunctionsErrorCode FIRFunctionsErrorCodeForName(NSString *name) {
   return @"UNKNOWN";
 }
 
-NSError *FUNErrorForResponse(NSInteger status, NSData *_Nullable body, FUNSerializer *serializer) {
+NSError *_Nullable FUNErrorForResponse(NSInteger status,
+                                       NSData *_Nullable body,
+                                       FUNSerializer *serializer) {
   // Start with reasonable defaults from the status code.
   FIRFunctionsErrorCode code = FIRFunctionsErrorCodeForHTTPStatus(status);
   NSString *description = FUNDescriptionForErrorCode(code);

Functions/FirebaseFunctions/FUNSerializer.m

@@ -152,7 +152,7 @@ - (id)decodeWrappedType:(NSDictionary *)wrapped error:(NSError **)error {
   if ([type isEqualToString:kLongType]) {
     NSNumberFormatter *formatter = [[NSNumberFormatter alloc] init];
     NSNumber *n = [formatter numberFromString:value];
-    if (!n) {
+    if (n == nil) {
       *error = FUNInvalidNumberError(value, wrapped);
       return nil;
     }