From 3dcbd83f888751cb881c600f07c8783aad67f009 Mon Sep 17 00:00:00 2001
From: Victor Fan <vsfan@google.com>
Date: Tue, 15 Nov 2022 17:23:58 -0800
Subject: [PATCH] Allow emitting eventarc channels as params

---
 src/runtime/manifest.ts      | 2 +-
 src/v2/options.ts            | 2 +-
 src/v2/providers/eventarc.ts | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/runtime/manifest.ts b/src/runtime/manifest.ts
index 6ff5fe0f9..c3f92226d 100644
--- a/src/runtime/manifest.ts
+++ b/src/runtime/manifest.ts
@@ -61,7 +61,7 @@ export interface ManifestEndpoint {
   eventTrigger?: {
     eventFilters: Record<string, string | Expression<string>>;
     eventFilterPathPatterns?: Record<string, string | Expression<string>>;
-    channel?: string;
+    channel?: string | Expression<string>;
     eventType: string;
     retry: boolean | Expression<boolean> | ResetValue;
     region?: string;
diff --git a/src/v2/options.ts b/src/v2/options.ts
index a4cc00eef..deddaf04a 100644
--- a/src/v2/options.ts
+++ b/src/v2/options.ts
@@ -258,7 +258,7 @@ export interface EventHandlerOptions extends Omit<GlobalOptions, "enforceAppChec
   serviceAccount?: string | ResetValue;
 
   /** The name of the channel where the function receives events. */
-  channel?: string;
+  channel?: string | Expression<string>;
 }
 
 /**
diff --git a/src/v2/providers/eventarc.ts b/src/v2/providers/eventarc.ts
index e765eb268..3485ae8c9 100644
--- a/src/v2/providers/eventarc.ts
+++ b/src/v2/providers/eventarc.ts
@@ -55,7 +55,7 @@ export interface EventarcTriggerOptions extends options.EventHandlerOptions {
    * If not specified, the default Firebase channel will be used:
    * `projects/{project}/locations/us-central1/channels/firebase`
    */
-  channel?: string;
+  channel?: string | Expression<string>;
 
   /**
    * Eventarc event exact match filter.