Skip to content

Commit e447949

Browse files
authored
fix: onRequest type definitions (#696)
1 parent ffd268a commit e447949

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/cloud-functions.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -281,7 +281,7 @@ export interface Runnable<T> {
281281
* arguments.
282282
*/
283283
export type HttpsFunction = TriggerAnnotated &
284-
((req: Request, resp: Response) => void);
284+
((req: Request, resp: Response) => void | Promise<void>);
285285

286286
/**
287287
* The Cloud Function type for all non-HTTPS triggers. This should be exported

src/providers/https.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ export interface Request extends express.Request {
3939
* same signature as an Express app.
4040
*/
4141
export function onRequest(
42-
handler: (req: Request, resp: express.Response) => void
42+
handler: (req: Request, resp: express.Response) => void | Promise<void>
4343
): HttpsFunction {
4444
return _onRequestWithOptions(handler, {});
4545
}
@@ -56,7 +56,7 @@ export function onCall(
5656

5757
/** @hidden */
5858
export function _onRequestWithOptions(
59-
handler: (req: Request, resp: express.Response) => void,
59+
handler: (req: Request, resp: express.Response) => void | Promise<void>,
6060
options: DeploymentOptions
6161
): HttpsFunction {
6262
// lets us add __trigger without altering handler:

0 commit comments

Comments
 (0)