From 68d9eda63ac3f3cd0e48e027dd8249468c912728 Mon Sep 17 00:00:00 2001 From: pawelsnk Date: Tue, 30 Nov 2021 13:26:39 +0100 Subject: [PATCH 1/5] Properly convert milliseconds to seconds Currently, a value expressed in milliseconds is directly assigned to a variable which is supposed to store seconds and it's later converted to mills again. Thus, convert properly upon assignment --- remote_config/src/desktop/remote_config_desktop.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/remote_config/src/desktop/remote_config_desktop.cc b/remote_config/src/desktop/remote_config_desktop.cc index 7e0bafdd03..624a77ebd5 100644 --- a/remote_config/src/desktop/remote_config_desktop.cc +++ b/remote_config/src/desktop/remote_config_desktop.cc @@ -140,7 +140,8 @@ Future RemoteConfigInternal::FetchAndActivate() { future_impl_.SafeAlloc(kRemoteConfigFnFetchAndActivate); cache_expiration_in_seconds_ = - config_settings_.minimum_fetch_interval_in_milliseconds; + config_settings_.minimum_fetch_interval_in_milliseconds / + ::firebase::internal::kMillisecondsPerSecond; uint64_t milliseconds_since_epoch = std::chrono::duration_cast( From 80fb7e2ce2a768a4a3cf66185f65241a3a9bc493 Mon Sep 17 00:00:00 2001 From: pawelsnk Date: Wed, 1 Dec 2021 08:48:53 +0100 Subject: [PATCH 2/5] Update readme.md --- release_build_files/readme.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/release_build_files/readme.md b/release_build_files/readme.md index 6f173209ad..42e4d1daec 100644 --- a/release_build_files/readme.md +++ b/release_build_files/readme.md @@ -580,6 +580,9 @@ code. ([#745](https://github.com/firebase/firebase-cpp-sdk/pull/745)) - Messaging (Android): Fixed crash during initialization. ([#760](https://github.com/firebase/firebase-cpp-sdk/pull/760)) + - Remote config (Desktop): Fixed cache expiration time value used by + FetchAndActivate(). + ([#767](https://github.com/firebase/firebase-cpp-sdk/pull/767)) ### 8.7.0 From 473b159f49a6b5bc5a65e3dc87155529b287cb52 Mon Sep 17 00:00:00 2001 From: pawelsnk Date: Wed, 1 Dec 2021 08:49:48 +0100 Subject: [PATCH 3/5] Update readme.md --- release_build_files/readme.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/release_build_files/readme.md b/release_build_files/readme.md index 42e4d1daec..c9b8339070 100644 --- a/release_build_files/readme.md +++ b/release_build_files/readme.md @@ -581,7 +581,7 @@ code. - Messaging (Android): Fixed crash during initialization. ([#760](https://github.com/firebase/firebase-cpp-sdk/pull/760)) - Remote config (Desktop): Fixed cache expiration time value used by - FetchAndActivate(). + `RemoteConfig::FetchAndActivate()`. ([#767](https://github.com/firebase/firebase-cpp-sdk/pull/767)) From cddd572b8466c362ee8fc192078f35f8795a39b9 Mon Sep 17 00:00:00 2001 From: pawelsnk Date: Thu, 2 Dec 2021 08:21:43 +0100 Subject: [PATCH 4/5] Fix indentation in readme. --- release_build_files/readme.md | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/release_build_files/readme.md b/release_build_files/readme.md index c9b8339070..c214c463a6 100644 --- a/release_build_files/readme.md +++ b/release_build_files/readme.md @@ -580,10 +580,9 @@ code. ([#745](https://github.com/firebase/firebase-cpp-sdk/pull/745)) - Messaging (Android): Fixed crash during initialization. ([#760](https://github.com/firebase/firebase-cpp-sdk/pull/760)) - - Remote config (Desktop): Fixed cache expiration time value used by - `RemoteConfig::FetchAndActivate()`. - ([#767](https://github.com/firebase/firebase-cpp-sdk/pull/767)) - + - Remote config (Desktop): Fixed cache expiration time value used by + `RemoteConfig::FetchAndActivate()`. + ([#767](https://github.com/firebase/firebase-cpp-sdk/pull/767)) ### 8.7.0 - Changes From e6847a69ade5243132194685f229fc2ccedf6733 Mon Sep 17 00:00:00 2001 From: pawelsnk Date: Thu, 2 Dec 2021 08:22:21 +0100 Subject: [PATCH 5/5] Fix case in readme --- release_build_files/readme.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/release_build_files/readme.md b/release_build_files/readme.md index c214c463a6..1507013896 100644 --- a/release_build_files/readme.md +++ b/release_build_files/readme.md @@ -580,7 +580,7 @@ code. ([#745](https://github.com/firebase/firebase-cpp-sdk/pull/745)) - Messaging (Android): Fixed crash during initialization. ([#760](https://github.com/firebase/firebase-cpp-sdk/pull/760)) - - Remote config (Desktop): Fixed cache expiration time value used by + - Remote Config (Desktop): Fixed cache expiration time value used by `RemoteConfig::FetchAndActivate()`. ([#767](https://github.com/firebase/firebase-cpp-sdk/pull/767))