From f2c4608aae67c0bbd852b5a04077c3f99dd2f68f Mon Sep 17 00:00:00 2001 From: Denver Coneybeare Date: Thu, 27 May 2021 15:16:02 -0400 Subject: [PATCH] Disable more bundles tests that fail in Windows CI --- firestore/integration_test_internal/src/bundle_test.cc | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/firestore/integration_test_internal/src/bundle_test.cc b/firestore/integration_test_internal/src/bundle_test.cc index 454be25e83..a3935a1b76 100644 --- a/firestore/integration_test_internal/src/bundle_test.cc +++ b/firestore/integration_test_internal/src/bundle_test.cc @@ -231,6 +231,10 @@ TEST_F(BundleTest, LoadInvalidBundlesShouldFail) { } TEST_F(BundleTest, LoadBundleWithDocumentsAlreadyPulledFromBackend) { + // TODO(wuandy, b/189477267): This test fails on Windows CI, but + // local run is fine. We need to figure out why and re-enable it. + SKIP_TEST_ON_WINDOWS; + Firestore* db = TestFirestore(); auto collection = db->Collection("coll-1"); WriteDocuments(collection, @@ -273,6 +277,10 @@ TEST_F(BundleTest, LoadBundleWithDocumentsAlreadyPulledFromBackend) { } TEST_F(BundleTest, LoadedDocumentsShouldNotBeGarbageCollectedRightAway) { + // TODO(wuandy, b/189477267): This test fails on Windows CI, but + // local run is fine. We need to figure out why and re-enable it. + SKIP_TEST_ON_WINDOWS; + Firestore* db = TestFirestore(); // This test really only makes sense with memory persistence, as disk // persistence only ever lazily deletes data.