Don't crash if the Remote Config backend sent an error. (#280)

jonsimantov · web-flow · commit e49f8e58689a · 2021-02-11T12:33:53.000-08:00
diff --git a/remote_config/src/desktop/remote_config_response.cc b/remote_config/src/desktop/remote_config_response.cc
@@ -94,7 +94,7 @@ void RemoteConfigResponse::MarkCompleted() {
   const fbs::Response* body_fbs =
       flatbuffers::GetRoot<fbs::Response>(builder.GetBufferPointer());
 
-  if (body_fbs->entries()->size() > 0) {
+  if (body_fbs && body_fbs->entries() && body_fbs->entries()->size() > 0) {
     entries_ = FlexbufferToVariant(body_fbs->entries_flexbuffer_root());
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -94,7 +94,7 @@ void RemoteConfigResponse::MarkCompleted() {`
`94`	`94`	`const fbs::Response* body_fbs =`
`95`	`95`	`flatbuffers::GetRoot<fbs::Response>(builder.GetBufferPointer());`
`96`	`96`
`97`		`- if (body_fbs->entries()->size() > 0) {`
	`97`	`+ if (body_fbs && body_fbs->entries() && body_fbs->entries()->size() > 0) {`
`98`	`98`	`entries_ = FlexbufferToVariant(body_fbs->entries_flexbuffer_root());`
`99`	`99`	`}`
`100`	`100`	`}`