@@ -356,8 +356,6 @@ void FirebaseGmaPreInitializationTests::SetUpTestSuite() {
356
356
357
357
// Test cases below.
358
358
359
- #if 0 // jsimantov
360
-
361
359
TEST_F (FirebaseGmaMinimalTest, TestInitializeGmaWithoutFirebase) {
362
360
// Don't initialize mediation in this test so that a later test can still
363
361
// verify that mediation has not been initialized.
@@ -2477,8 +2475,6 @@ TEST_F(FirebaseGmaTest, TestAdViewMultithreadDeletion) {
2477
2475
#endif // #if defined(ANDROID) || (defined(TARGET_OS_IPHONE) &&
2478
2476
// TARGET_OS_IPHONE)
2479
2477
2480
- #endif // 0 // jsimantov
2481
-
2482
2478
class FirebaseGmaUmpTest : public FirebaseGmaTest {
2483
2479
public:
2484
2480
FirebaseGmaUmpTest () : consent_info_(nullptr ) {}
@@ -2962,7 +2958,8 @@ TEST_F(FirebaseGmaUmpTest, TestUmpMethodsReturnOperationInProgress) {
2962
2958
ConsentRequestParameters params;
2963
2959
params.tag_for_under_age_of_consent = false ;
2964
2960
params.debug_settings .debug_geography =
2965
- firebase::gma::ump::kConsentDebugGeographyEEA ;
2961
+ ShouldRunUITests () ? firebase::gma::ump::kConsentDebugGeographyEEA
2962
+ : firebase::gma::ump::kConsentDebugGeographyNonEEA ;
2966
2963
params.debug_settings .debug_device_ids = kTestDeviceIDs ;
2967
2964
params.debug_settings .debug_device_ids .push_back (GetDebugDeviceId ());
2968
2965
@@ -2977,17 +2974,17 @@ TEST_F(FirebaseGmaUmpTest, TestUmpMethodsReturnOperationInProgress) {
2977
2974
WaitForCompletion (future_request_1, " RequestConsentInfoUpdate first" );
2978
2975
FLAKY_TEST_SECTION_END ();
2979
2976
2980
- FLAKY_TEST_SECTION_BEGIN ();
2981
- firebase::Future<void > future_load_1 = consent_info_->LoadConsentForm ();
2982
- firebase::Future<void > future_load_2 = consent_info_->LoadConsentForm ();
2983
- WaitForCompletion (future_load_2, " LoadConsentForm second" ,
2984
- firebase::gma::ump::kConsentFormErrorOperationInProgress );
2985
- WaitForCompletion (future_load_1, " LoadConsentForm first" );
2986
- FLAKY_TEST_SECTION_END ();
2987
-
2988
2977
if (ShouldRunUITests ()) {
2989
2978
// The below should only be checked if UI tests are enabled, as they
2990
2979
// require some interaction.
2980
+ FLAKY_TEST_SECTION_BEGIN ();
2981
+ firebase::Future<void > future_load_1 = consent_info_->LoadConsentForm ();
2982
+ firebase::Future<void > future_load_2 = consent_info_->LoadConsentForm ();
2983
+ WaitForCompletion (future_load_2, " LoadConsentForm second" ,
2984
+ firebase::gma::ump::kConsentFormErrorOperationInProgress );
2985
+ WaitForCompletion (future_load_1, " LoadConsentForm first" );
2986
+ FLAKY_TEST_SECTION_END ();
2987
+
2991
2988
FLAKY_TEST_SECTION_BEGIN ();
2992
2989
firebase::Future<void > future_show_1 =
2993
2990
consent_info_->ShowConsentForm (app_framework::GetWindowController ());
0 commit comments