Skip to content

Commit 8b17dbf

Browse files
committed
Don't ignore firestore namespace when checking for invalid ones
1 parent c1b0c6f commit 8b17dbf

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.github/workflows/cpp-packaging.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -635,7 +635,7 @@ jobs:
635635
# get a list of all top-level namespaces (except system namespaces)
636636
cat cpp_symbols.txt | grep -v '^std::' | grep -v '^__gnu_cxx::' | cut -d: -f1 | sort | uniq > cpp_namespaces.txt
637637
# Filter out the renamed namespaces (f_b_*) and the public namespace (firebase)
638-
cat cpp_namespaces.txt | grep -v '^f_b_' | grep -v '^firebase$' | grep -v '^firestore$' > extra_namespaces.txt
638+
cat cpp_namespaces.txt | grep -v '^f_b_' | grep -v '^firebase$' | > extra_namespaces.txt
639639
# If there are any namespaces in this file, print an error.
640640
if [[ -s extra_namespaces.txt ]]; then
641641
echo '::error ::Unrenamed C++ namespaces in ${{ matrix.sdk_platform }}${{ matrix.suffix }} package:%0A'$(cat extra_namespaces.txt | tr '\n' ' ' | sed 's/ /%0A/g')

0 commit comments

Comments
 (0)