Skip to content

Commit 5c7390c

Browse files
authored
Disable more bundles tests that fail in Windows CI (#440)
1 parent e8e6a45 commit 5c7390c

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

firestore/integration_test_internal/src/bundle_test.cc

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -231,6 +231,10 @@ TEST_F(BundleTest, LoadInvalidBundlesShouldFail) {
231231
}
232232

233233
TEST_F(BundleTest, LoadBundleWithDocumentsAlreadyPulledFromBackend) {
234+
// TODO(wuandy, b/189477267): This test fails on Windows CI, but
235+
// local run is fine. We need to figure out why and re-enable it.
236+
SKIP_TEST_ON_WINDOWS;
237+
234238
Firestore* db = TestFirestore();
235239
auto collection = db->Collection("coll-1");
236240
WriteDocuments(collection,
@@ -273,6 +277,10 @@ TEST_F(BundleTest, LoadBundleWithDocumentsAlreadyPulledFromBackend) {
273277
}
274278

275279
TEST_F(BundleTest, LoadedDocumentsShouldNotBeGarbageCollectedRightAway) {
280+
// TODO(wuandy, b/189477267): This test fails on Windows CI, but
281+
// local run is fine. We need to figure out why and re-enable it.
282+
SKIP_TEST_ON_WINDOWS;
283+
276284
Firestore* db = TestFirestore();
277285
// This test really only makes sense with memory persistence, as disk
278286
// persistence only ever lazily deletes data.

0 commit comments

Comments
 (0)