Skip to content

Commit 3a58ecd

Browse files
authored
use windows-2016 in all builds which compile boringssl (#444)
This change updates the Integration Test and Packaging workflows to use windows-2016 GHA runners. Details: GHA is rolling out a new version of windows server 2019 tools (windows-2019 / windows-latest alias) which produce a [C4255 warning](https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-4-c4255?view=msvc-160) in BoringSSL. BoringSSL is configured to error on all warnings, and so our current CI is broken until we can figure out the best way to properly patch the BoringSSL cmake configuration.
1 parent fa07fae commit 3a58ecd

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

.github/workflows/cpp-packaging.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -246,18 +246,18 @@ jobs:
246246
strategy:
247247
fail-fast: false
248248
matrix:
249-
os: [windows-latest, ubuntu-latest, macos-latest]
249+
os: [windows-2016, ubuntu-latest, macos-latest]
250250
build_type: ["Release", "Debug"]
251251
architecture: ["x64", "x86"]
252252
msvc_runtime: ["static", "dynamic"]
253253
linux_abi: ["legacy", "c++11"]
254254
python_version: [3.7]
255255
include:
256-
- os: windows-latest
256+
- os: windows-2016
257257
vcpkg_triplet_suffix: "windows-static"
258258
additional_build_flags: "--build_tests"
259259
sdk_platform: "windows"
260-
- os: windows-latest
260+
- os: windows-2016
261261
msvc_runtime: "dynamic"
262262
vcpkg_triplet_suffix: "windows-static-md"
263263
additional_build_flags: "--build_tests"
@@ -272,7 +272,7 @@ jobs:
272272
sdk_platform: "darwin"
273273

274274
exclude:
275-
- os: windows-latest
275+
- os: windows-2016
276276
linux_abi: "c++11"
277277
- os: macos-latest
278278
architecture: "x86"

.github/workflows/integration_tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ on:
1818
required: true
1919
operating_systems:
2020
description: 'CSV of VMs to run on'
21-
default: 'ubuntu-latest,windows-latest,macos-latest'
21+
default: 'ubuntu-latest,windows-2016,macos-latest'
2222
required: true
2323
desktop_ssl_variants:
2424
description: 'CSV of desktop SSL variants to use'

scripts/gha/print_matrix_configuration.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@
9797

9898
"integration_tests": {
9999
"matrix": {
100-
"os": ["ubuntu-latest", "macos-latest", "windows-latest"],
100+
"os": ["ubuntu-latest", "macos-latest", "windows-2016"],
101101
"platform": ["Desktop", "Android", "iOS"],
102102
"ssl_lib": ["openssl", "boringssl"],
103103
"android_device": ["virtual:system-images;android-28;google_apis;x86_64+28.0.3", "real:flame+29"],

0 commit comments

Comments
 (0)