Skip to content

Commit 344fefe

Browse files
committed
Fixes from code review
1 parent 2eeacdd commit 344fefe

File tree

3 files changed

+8
-2
lines changed

3 files changed

+8
-2
lines changed

firestore/src/android/query_android.h

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,12 @@ class QueryInternal : public Wrapper {
7171
*/
7272
virtual AggregateQuery Count() const;
7373

74+
/**
75+
* @brief Creates and returns a new Query with the additional filter.
76+
*
77+
* @param filter The new filter to apply to the existing query.
78+
* @return The created Query.
79+
*/
7480
Query Where(const Filter& filter) const;
7581

7682
/**

firestore/src/android/wrapper.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ Wrapper::Wrapper(Wrapper* rhs) : Wrapper() {
6060

6161
Wrapper::~Wrapper() = default;
6262

63-
jni::Env Wrapper::GetEnv() { return FirestoreInternal::GetEnv(); }
63+
jni::Env Wrapper::GetEnv() const { return firestore_->GetEnv(); }
6464

6565
Local<Object> Wrapper::ToJava() const {
6666
Env env = GetEnv();

firestore/src/android/wrapper.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ class Wrapper {
5555
// Similar to a copy constructor, but can handle the case where `rhs` is null.
5656
explicit Wrapper(Wrapper* rhs);
5757

58-
static jni::Env GetEnv();
58+
jni::Env GetEnv() const;
5959

6060
FirestoreInternal* firestore_ = nullptr; // not owning
6161
jni::ArenaRef obj_;

0 commit comments

Comments
 (0)