minor fixes

Author: AlmostMatt

remote_config/integration_test/src/integration_test.cc

@@ -200,8 +200,12 @@ TEST_F(FirebaseRemoteConfigTest, TestAddOnConfigUpdateListener) {
 
   EXPECT_TRUE(WaitForCompletion(SetDefaults(rc_), "SetDefaults"));
 
-#if FIREBASE_PLATFORM_IOS
-
+// Realtime RC is not yet supported on desktop.
+#if FIREBASE_PLATFORM_DESKTOP
+  EXPECT_EQ(nullptr, rc_->AddOnConfigUpdateListener(
+                          [](firebase::remote_config::ConfigUpdate&&,
+                             firebase::remote_config::RemoteConfigError) {}));
+#else
   auto config_update_promise = std::make_shared<std::promise<void>>();
 
   firebase::remote_config::ConfigUpdateListenerRegistration* registration =

remote_config/remote_config_resources/build.gradle

@@ -50,7 +50,7 @@ android {
 
 dependencies {
   implementation platform('com.google.firebase:firebase-bom:31.2.0')
-  implementation 'com.google.firebase:firebase-remote_config'
+  implementation 'com.google.firebase:firebase-config'
 }
 
 afterEvaluate {

remote_config/src/android/remote_config_android.cc

@@ -1179,6 +1179,8 @@ RemoteConfigInternal::AddOnConfigUpdateListener(
     ConfigUpdateListenerRegistration *registration_wrapper =
       new ConfigUpdateListenerRegistration([j_registration]() {
         // TODO almostmatt - get threadsafe jni env. see appcheck.
+        // alternatively, define a new type for android ConfigUpdateListenerRegistration
+        // and give it the pointer and let it handle global ref in its destructor
         env->CallVoidMethod(j_registration,
                             config_update_listener_registration::GetMethodId(
                               config_update_listener_registration::kRemove));