From 7ebb113d580e8e5337424f7578913c1d60baf38f Mon Sep 17 00:00:00 2001
From: utzcoz <utzcoz@outlook.com>
Date: Sat, 22 Jul 2023 21:48:45 +0800
Subject: [PATCH] Fix lint erors

Signed-off-by: utzcoz <utzcoz@outlook.com>
---
 .../firebase-inappmessaging-display.gradle    |   4 +
 .../lint-baseline.xml                         | 139 ++++++++++++++++++
 .../firebase-ml-modeldownloader.gradle        |   3 +
 firebase-ml-modeldownloader/lint-baseline.xml |  81 ++++++++++
 4 files changed, 227 insertions(+)
 create mode 100644 firebase-inappmessaging-display/lint-baseline.xml
 create mode 100644 firebase-ml-modeldownloader/lint-baseline.xml

diff --git a/firebase-inappmessaging-display/firebase-inappmessaging-display.gradle b/firebase-inappmessaging-display/firebase-inappmessaging-display.gradle
index 75bfe5e5c04..3a1243b51c6 100644
--- a/firebase-inappmessaging-display/firebase-inappmessaging-display.gradle
+++ b/firebase-inappmessaging-display/firebase-inappmessaging-display.gradle
@@ -42,6 +42,10 @@ android {
         disable "GradleCompatible"
     }
 
+    lint {
+        baseline = file("lint-baseline.xml")
+    }
+
     compileOptions {
         sourceCompatibility JavaVersion.VERSION_1_8
         targetCompatibility JavaVersion.VERSION_1_8
diff --git a/firebase-inappmessaging-display/lint-baseline.xml b/firebase-inappmessaging-display/lint-baseline.xml
new file mode 100644
index 00000000000..f8cff6e402d
--- /dev/null
+++ b/firebase-inappmessaging-display/lint-baseline.xml
@@ -0,0 +1,139 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<issues format="6" by="lint 7.4.2" type="baseline" client="gradle" dependencies="false" name="AGP (7.4.2)" variant="all" version="7.4.2">
+
+    <issue
+        id="CheckResult"
+        message="The result of `placeholder` is not used"
+        errorLine1="      requestBuilder.placeholder(placeholderResId);"
+        errorLine2="      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
+        <location
+            file="src/main/java/com/google/firebase/inappmessaging/display/internal/FiamImageLoader.java"
+            line="95"
+            column="7"/>
+    </issue>
+
+    <issue
+        id="WrongConstant"
+        message="Must be one or more of: Gravity.FILL, Gravity.FILL_HORIZONTAL, Gravity.FILL_VERTICAL, Gravity.START, Gravity.END, Gravity.LEFT, Gravity.RIGHT, Gravity.TOP, Gravity.BOTTOM, Gravity.CENTER, Gravity.CENTER_HORIZONTAL, Gravity.CENTER_VERTICAL, Gravity.DISPLAY_CLIP_HORIZONTAL, Gravity.DISPLAY_CLIP_VERTICAL, Gravity.CLIP_HORIZONTAL, Gravity.CLIP_VERTICAL, Gravity.NO_GRAVITY"
+        errorLine1="    layoutParams.gravity = layoutConfig.viewWindowGravity();"
+        errorLine2="                           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
+        <location
+            file="src/main/java/com/google/firebase/inappmessaging/display/internal/FiamWindowManager.java"
+            line="120"
+            column="28"/>
+    </issue>
+
+    <issue
+        id="InflateParams"
+        message="Avoid passing `null` as the view root (needed to resolve layout parameters on the inflated layout&apos;s root element)"
+        errorLine1="    View root = inflater.inflate(R.layout.banner, null);"
+        errorLine2="                                                  ~~~~">
+        <location
+            file="src/main/java/com/google/firebase/inappmessaging/display/internal/bindingwrappers/BannerBindingWrapper.java"
+            line="67"
+            column="51"/>
+    </issue>
+
+    <issue
+        id="InflateParams"
+        message="Avoid passing `null` as the view root (needed to resolve layout parameters on the inflated layout&apos;s root element)"
+        errorLine1="    View root = inflater.inflate(R.layout.card, null);"
+        errorLine2="                                                ~~~~">
+        <location
+            file="src/main/java/com/google/firebase/inappmessaging/display/internal/bindingwrappers/CardBindingWrapper.java"
+            line="72"
+            column="49"/>
+    </issue>
+
+    <issue
+        id="InflateParams"
+        message="Avoid passing `null` as the view root (needed to resolve layout parameters on the inflated layout&apos;s root element)"
+        errorLine1="    View v = inflater.inflate(R.layout.image, null);"
+        errorLine2="                                              ~~~~">
+        <location
+            file="src/main/java/com/google/firebase/inappmessaging/display/internal/bindingwrappers/ImageBindingWrapper.java"
+            line="65"
+            column="47"/>
+    </issue>
+
+    <issue
+        id="InflateParams"
+        message="Avoid passing `null` as the view root (needed to resolve layout parameters on the inflated layout&apos;s root element)"
+        errorLine1="    View root = inflater.inflate(R.layout.modal, null);"
+        errorLine2="                                                 ~~~~">
+        <location
+            file="src/main/java/com/google/firebase/inappmessaging/display/internal/bindingwrappers/ModalBindingWrapper.java"
+            line="72"
+            column="50"/>
+    </issue>
+
+    <issue
+        id="DisableBaselineAlignment"
+        message="Set `android:baselineAligned=&quot;false&quot;` on this element for better performance"
+        errorLine1="    &lt;LinearLayout"
+        errorLine2="     ~~~~~~~~~~~~">
+        <location
+            file="src/main/res/layout/banner.xml"
+            line="12"
+            column="6"/>
+    </issue>
+
+    <issue
+        id="UnusedResources"
+        message="The resource `R.drawable.placeholder_50_50` appears to be unused">
+        <location
+            file="src/debug/res/drawable-mdpi/placeholder_50_50.png"/>
+    </issue>
+
+    <issue
+        id="UnusedResources"
+        message="The resource `R.string.card_content_descriptor` appears to be unused"
+        errorLine1="  &lt;string name=&quot;card_content_descriptor&quot;>card&lt;/string>"
+        errorLine2="          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
+        <location
+            file="src/main/res/values/strings.xml"
+            line="3"
+            column="11"/>
+    </issue>
+
+    <issue
+        id="ContentDescription"
+        message="Missing `contentDescription` attribute on image"
+        errorLine1="    &lt;ImageView"
+        errorLine2="     ~~~~~~~~~">
+        <location
+            file="src/main/res/layout-land/card_landscape_inner.xml"
+            line="16"
+            column="6"/>
+    </issue>
+
+    <issue
+        id="ContentDescription"
+        message="Missing `contentDescription` attribute on image"
+        errorLine1="    &lt;ImageView"
+        errorLine2="     ~~~~~~~~~">
+        <location
+            file="src/main/res/layout/card_portrait_inner.xml"
+            line="14"
+            column="6"/>
+    </issue>
+
+    <issue
+        id="RtlEnabled"
+        message="The project references RTL attributes, but does not explicitly enable or disable RTL support with `android:supportsRtl` in the manifest">
+        <location
+            file="src/main/AndroidManifest.xml"/>
+    </issue>
+
+    <issue
+        id="IgnoreWithoutReason"
+        message="Test is ignored without giving any explanation"
+        errorLine1="  @Ignore"
+        errorLine2="  ~~~~~~~">
+        <location
+            file="src/test/java/com/google/firebase/inappmessaging/display/FirebaseInAppMessagingDisplayTest.java"
+            line="366"
+            column="3"/>
+    </issue>
+
+</issues>
diff --git a/firebase-ml-modeldownloader/firebase-ml-modeldownloader.gradle b/firebase-ml-modeldownloader/firebase-ml-modeldownloader.gradle
index e42523e54b5..1bb0f3601bc 100644
--- a/firebase-ml-modeldownloader/firebase-ml-modeldownloader.gradle
+++ b/firebase-ml-modeldownloader/firebase-ml-modeldownloader.gradle
@@ -59,6 +59,9 @@ android {
             includeAndroidResources = true
         }
     }
+    lint {
+        baseline = file("lint-baseline.xml")
+    }
 }
 
 thirdPartyLicenses {
diff --git a/firebase-ml-modeldownloader/lint-baseline.xml b/firebase-ml-modeldownloader/lint-baseline.xml
new file mode 100644
index 00000000000..5b5232cdef7
--- /dev/null
+++ b/firebase-ml-modeldownloader/lint-baseline.xml
@@ -0,0 +1,81 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<issues format="6" by="lint 7.3.1" type="baseline" client="gradle" dependencies="false" name="AGP (7.3.1)" variant="all" version="7.3.1">
+
+    <issue
+        id="ApplySharedPref"
+        message="Consider using `apply()` instead; `commit` writes its data to persistent storage immediately, whereas `apply` will handle it in the background"
+        errorLine1="        .commit();"
+        errorLine2="         ~~~~~~~~">
+        <location
+            file="src/main/java/com/google/firebase/ml/modeldownloader/internal/SharedPreferencesUtil.java"
+            line="164"
+            column="10"/>
+    </issue>
+
+    <issue
+        id="ApplySharedPref"
+        message="Consider using `apply()` instead; `commit` writes its data to persistent storage immediately, whereas `apply` will handle it in the background"
+        errorLine1="        .commit();"
+        errorLine2="         ~~~~~~~~">
+        <location
+            file="src/main/java/com/google/firebase/ml/modeldownloader/internal/SharedPreferencesUtil.java"
+            line="192"
+            column="10"/>
+    </issue>
+
+    <issue
+        id="ApplySharedPref"
+        message="Consider using `apply()` instead; `commit` writes its data to persistent storage immediately, whereas `apply` will handle it in the background"
+        errorLine1="        .commit();"
+        errorLine2="         ~~~~~~~~">
+        <location
+            file="src/main/java/com/google/firebase/ml/modeldownloader/internal/SharedPreferencesUtil.java"
+            line="226"
+            column="10"/>
+    </issue>
+
+    <issue
+        id="ApplySharedPref"
+        message="Consider using `apply()` instead; `commit` writes its data to persistent storage immediately, whereas `apply` will handle it in the background"
+        errorLine1="          .commit();"
+        errorLine2="           ~~~~~~~~">
+        <location
+            file="src/main/java/com/google/firebase/ml/modeldownloader/internal/SharedPreferencesUtil.java"
+            line="317"
+            column="12"/>
+    </issue>
+
+    <issue
+        id="ApplySharedPref"
+        message="Consider using `apply()` instead; `commit` writes its data to persistent storage immediately, whereas `apply` will handle it in the background"
+        errorLine1="          .commit();"
+        errorLine2="           ~~~~~~~~">
+        <location
+            file="src/main/java/com/google/firebase/ml/modeldownloader/internal/SharedPreferencesUtil.java"
+            line="324"
+            column="12"/>
+    </issue>
+
+    <issue
+        id="Range"
+        message="Value must be ≥ 0 but `getColumnIndex` can be -1"
+        errorLine1="        statusCode = cursor.getInt(cursor.getColumnIndex(DownloadManager.COLUMN_STATUS));"
+        errorLine2="                                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
+        <location
+            file="src/main/java/com/google/firebase/ml/modeldownloader/internal/ModelFileDownloadService.java"
+            line="318"
+            column="36"/>
+    </issue>
+
+    <issue
+        id="Range"
+        message="Value must be ≥ 0 but `getColumnIndex` can be -1"
+        errorLine1="      int reason = cursor.getInt(cursor.getColumnIndex(DownloadManager.COLUMN_REASON));"
+        errorLine2="                                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
+        <location
+            file="src/main/java/com/google/firebase/ml/modeldownloader/internal/ModelFileDownloadService.java"
+            line="476"
+            column="34"/>
+    </issue>
+
+</issues>