Skip to content

fix log #4811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2023
Merged

fix log #4811

merged 1 commit into from
Mar 22, 2023

Conversation

themiswang
Copy link
Contributor

Update the change log for M129 to reflect the change we make for this release

@github-actions
Copy link
Contributor

github-actions bot commented Mar 22, 2023

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

Add the 'main-merge-ack' label to your PR to confirm merging into the main branch is intended.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 22, 2023

@themiswang themiswang force-pushed the crashlyticsLogChange branch from 76aa3c6 to 5d2cdd1 Compare March 22, 2023 16:05
@google-oss-bot
Copy link
Contributor

@github-actions
Copy link
Contributor

Unit Test Results

  6 files  ±0    6 suites  ±0   27s ⏱️ +10s
18 tests ±0  18 ✔️ ±0  0 💤 ±0  0 ±0 
36 runs  ±0  36 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 5d2cdd1. ± Comparison against base commit cad784b.

@google-oss-bot
Copy link
Contributor

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

Startup Times

  • fire-cls

    DeviceStatisticsDistributions
    oriole-32
    Percentilecad784bf1c907eDiffSignificant (?)
    p1011.5 ±3 ms10.9 ±3 ms-588 μs (-5.1%)NO
    p2512.6 ±4 ms11.7 ±3 ms-886 μs (-7.0%)NO
    p5013.9 ±4 ms12.7 ±3 ms-1.16 ms (-8.3%)NO
    p7515.4 ±4 ms14.0 ±3 ms-1.39 ms (-9.0%)NO
    p9017.1 ±4 ms15.9 ±3 ms-1.20 ms (-7.0%)NO

    20 test runs in comparison
    CommitTest Runs
    cad784b
    • 2023-03-22_13:26:37.185983_Dbvs
    • 2023-03-22_13:26:37.188539_pqiu
    • 2023-03-22_13:26:37.188550_GOOM
    • 2023-03-22_13:26:37.188556_pJiJ
    • 2023-03-22_13:26:37.188561_TgUS
    • 2023-03-22_13:26:37.188567_ifWD
    • 2023-03-22_13:26:37.188573_GVIz
    • 2023-03-22_13:26:37.188579_eKsS
    • 2023-03-22_13:26:37.188584_FeyY
    • 2023-03-22_13:26:37.188589_AYLf
    f1c907e
    • 2023-03-22_16:26:09.447106_dDJd
    • 2023-03-22_16:26:09.459396_DmfI
    • 2023-03-22_16:26:09.459625_VSxg
    • 2023-03-22_16:26:09.459640_WwlM
    • 2023-03-22_16:26:09.459647_QqAA
    • 2023-03-22_16:26:09.459653_Qdpk
    • 2023-03-22_16:26:09.459659_eFnF
    • 2023-03-22_16:26:09.459665_Ivqg
    • 2023-03-22_16:26:09.459671_jLXM
    • 2023-03-22_16:26:09.459676_nSFE
    redfin-30
    Percentilecad784bf1c907eDiffSignificant (?)
    p1013.5 ±5 ms16.1 ±6 ms+2.62 ms (+19.5%)NO
    p2514.4 ±5 ms17.3 ±7 ms+2.95 ms (+20.6%)NO
    p5015.7 ±6 ms19.1 ±8 ms+3.44 ms (+22.0%)NO
    p7517.7 ±7 ms21.4 ±9 ms+3.76 ms (+21.3%)NO
    p9020.2 ±8 ms24.9 ±11 ms+4.65 ms (+23.0%)NO

    20 test runs in comparison
    CommitTest Runs
    cad784b
    • 2023-03-22_13:26:37.185983_Dbvs
    • 2023-03-22_13:26:37.188539_pqiu
    • 2023-03-22_13:26:37.188550_GOOM
    • 2023-03-22_13:26:37.188556_pJiJ
    • 2023-03-22_13:26:37.188561_TgUS
    • 2023-03-22_13:26:37.188567_ifWD
    • 2023-03-22_13:26:37.188573_GVIz
    • 2023-03-22_13:26:37.188579_eKsS
    • 2023-03-22_13:26:37.188584_FeyY
    • 2023-03-22_13:26:37.188589_AYLf
    f1c907e
    • 2023-03-22_16:26:09.447106_dDJd
    • 2023-03-22_16:26:09.459396_DmfI
    • 2023-03-22_16:26:09.459625_VSxg
    • 2023-03-22_16:26:09.459640_WwlM
    • 2023-03-22_16:26:09.459647_QqAA
    • 2023-03-22_16:26:09.459653_Qdpk
    • 2023-03-22_16:26:09.459659_eFnF
    • 2023-03-22_16:26:09.459665_Ivqg
    • 2023-03-22_16:26:09.459671_jLXM
    • 2023-03-22_16:26:09.459676_nSFE
  • timeToInitialDisplay

    DeviceStatisticsDistributions
    oriole-32
    Percentilecad784bf1c907eDiffSignificant (?)
    p10201 ±19 ms195 ±2 ms-6.44 ms (-3.2%)NO
    p25214 ±31 ms200 ±3 ms-13.5 ms (-6.3%)NO
    p50227 ±39 ms208 ±4 ms-18.8 ms (-8.3%)NO
    p75242 ±48 ms218 ±3 ms-23.7 ms (-9.8%)NO
    p90255 ±59 ms232 ±7 ms-23.0 ms (-9.0%)NO

    20 test runs in comparison
    CommitTest Runs
    cad784b
    • 2023-03-22_13:26:37.185983_Dbvs
    • 2023-03-22_13:26:37.188539_pqiu
    • 2023-03-22_13:26:37.188550_GOOM
    • 2023-03-22_13:26:37.188556_pJiJ
    • 2023-03-22_13:26:37.188561_TgUS
    • 2023-03-22_13:26:37.188567_ifWD
    • 2023-03-22_13:26:37.188573_GVIz
    • 2023-03-22_13:26:37.188579_eKsS
    • 2023-03-22_13:26:37.188584_FeyY
    • 2023-03-22_13:26:37.188589_AYLf
    f1c907e
    • 2023-03-22_16:26:09.447106_dDJd
    • 2023-03-22_16:26:09.459396_DmfI
    • 2023-03-22_16:26:09.459625_VSxg
    • 2023-03-22_16:26:09.459640_WwlM
    • 2023-03-22_16:26:09.459647_QqAA
    • 2023-03-22_16:26:09.459653_Qdpk
    • 2023-03-22_16:26:09.459659_eFnF
    • 2023-03-22_16:26:09.459665_Ivqg
    • 2023-03-22_16:26:09.459671_jLXM
    • 2023-03-22_16:26:09.459676_nSFE
    redfin-30
    Percentilecad784bf1c907eDiffSignificant (?)
    p10232 ±3 ms254 ±5 ms+22.9 ms (+9.9%)YES
    p25237 ±4 ms260 ±4 ms+22.6 ms (+9.5%)YES
    p50245 ±4 ms267 ±4 ms+22.3 ms (+9.1%)YES
    p75253 ±5 ms276 ±5 ms+23.5 ms (+9.3%)YES
    p90262 ±6 ms289 ±7 ms+26.3 ms (+10.0%)MAYBE

    20 test runs in comparison
    CommitTest Runs
    cad784b
    • 2023-03-22_13:26:37.185983_Dbvs
    • 2023-03-22_13:26:37.188539_pqiu
    • 2023-03-22_13:26:37.188550_GOOM
    • 2023-03-22_13:26:37.188556_pJiJ
    • 2023-03-22_13:26:37.188561_TgUS
    • 2023-03-22_13:26:37.188567_ifWD
    • 2023-03-22_13:26:37.188573_GVIz
    • 2023-03-22_13:26:37.188579_eKsS
    • 2023-03-22_13:26:37.188584_FeyY
    • 2023-03-22_13:26:37.188589_AYLf
    f1c907e
    • 2023-03-22_16:26:09.447106_dDJd
    • 2023-03-22_16:26:09.459396_DmfI
    • 2023-03-22_16:26:09.459625_VSxg
    • 2023-03-22_16:26:09.459640_WwlM
    • 2023-03-22_16:26:09.459647_QqAA
    • 2023-03-22_16:26:09.459653_Qdpk
    • 2023-03-22_16:26:09.459659_eFnF
    • 2023-03-22_16:26:09.459665_Ivqg
    • 2023-03-22_16:26:09.459671_jLXM
    • 2023-03-22_16:26:09.459676_nSFE

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/QgN6CkhLuL/index.html

@themiswang themiswang requested a review from emilypgoogle March 22, 2023 17:38
@themiswang themiswang merged commit c51a44f into master Mar 22, 2023
@themiswang themiswang deleted the crashlyticsLogChange branch March 22, 2023 19:18
@firebase firebase locked and limited conversation to collaborators Apr 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants