From dc61f47f79ab22f63d860017445a2d386212b24a Mon Sep 17 00:00:00 2001 From: Rodrigo Lazo Date: Tue, 13 Sep 2022 18:23:10 -0400 Subject: [PATCH 1/2] Enable CHANGELOG check globally --- ci/danger/Dangerfile | 15 +-------------- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/ci/danger/Dangerfile b/ci/danger/Dangerfile index 23c578283cb..5cab1470980 100644 --- a/ci/danger/Dangerfile +++ b/ci/danger/Dangerfile @@ -71,25 +71,12 @@ def has_sdk_changes() } end -tester_team = [ - 'rlazo', - 'vkryachko', - 'yifanyang', - 'VinayGuthal', - 'davidmotson', - 'daymxn', - 'emilypgoogle' -] - -is_enabled = true if tester_team.include? github.pr_author - ### Actions # Warn if a changelog is left out on a non-trivial PR that has modified # SDK source files. # -# TODO: remove the `is_enabled` after tests are complete -if is_enabled && has_sdk_changes() +if has_sdk_changes() if !has_changelog_changes && !declared_trivial warning = "Did you forget to add a changelog entry? (Add the 'no-changelog'"\ " label to the PR to silence this warning.)" From 796ccc76e9cc21771cb61b8948121d2e7b430eff Mon Sep 17 00:00:00 2001 From: Rodrigo Lazo Date: Tue, 13 Sep 2022 18:25:51 -0400 Subject: [PATCH 2/2] Simplify conditional. --- ci/danger/Dangerfile | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/ci/danger/Dangerfile b/ci/danger/Dangerfile index 5cab1470980..0efe1369e0b 100644 --- a/ci/danger/Dangerfile +++ b/ci/danger/Dangerfile @@ -76,10 +76,8 @@ end # Warn if a changelog is left out on a non-trivial PR that has modified # SDK source files. # -if has_sdk_changes() - if !has_changelog_changes && !declared_trivial - warning = "Did you forget to add a changelog entry? (Add the 'no-changelog'"\ - " label to the PR to silence this warning.)" - warn(warning) - end +if has_sdk_changes() && !has_changelog_changes && !declared_trivial + warning = "Did you forget to add a changelog entry? (Add the 'no-changelog'"\ + " label to the PR to silence this warning.)" + warn(warning) end