-
Notifications
You must be signed in to change notification settings - Fork 614
[Feature Request] ML Kit: On-Device Model Download API #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks @ParthPadg for the feedback! This was also requested here: We are tracking this bug internally. @bjornick what should we do for reports like this that are about SDKs that are not yet part of this repo? Should we file an internal bug and then close them? Leave them open here with a certain label? |
@samtstern Okay! I didn't check the QuickStart repo for duplicates, sorry. |
@ParthPadg no worries, I would not expect you to check for dupes there. That's a good clarification, I'll update the internal discussion with that note. |
I think we should file an internal bug for the ML Kit team to use, but leave this issue open until it is fixed. I'm not sure what the right tag to apply here is though. |
@bjornick cool, the internal bug already exists. I added a |
Any update on this issue? Is it possible to bundle a default model (e.g., face) in the app binary, and bypass this whole issue? |
We need an offline model bundled with the app for users with no network access. |
is there any update? |
Any updates? we're getting some errors and edge cases due to models not being ready on time. |
Any updates? My users very often get this error. Approximately 10% of users. This is a lot! |
This should be solved with the new FirebaseModelManager API. |
This example raises many questions. I will look at the source code a bit later to understand how it works. For example, for firebaseModelManager.isModelDownloaded, there is a constant:
Perhaps past questions are superfluous ...
|
Another reason to have an embedded model is because some users download apps from different app stores (e.g. HiMarket, Samsung, Tencent, etc.) and in most cases don't have the Google Play Services installed. So I'd like to reinforce the necessity to have an embedded model (it may be a lightweight version, just to have the feature working properly) to avoid this kind of issues. |
This is also an issue when the app is downloaded through any MDM system. The current API forces us to use another OCR solution. |
One reasons some downloads may be failing is if your device has an out of date version of Google Play services. You can use the methods of |
I'd like to request an API to query the download status for MLKit's on-device models.
Ideally, this API would allow the following:
UNAVAILABLE
,AVAILABLE
,DOWNLOADING
, etc.Task<Void
)Here's the current documentation with regards to on-device models:
(from https://firebase.google.com/docs/ml-kit/android/read-barcodes, emphasis mine)
I think it's crucial to have APIs to monitor the state of the on-device models, especially since the system makes no guarantees about when the "runtime" download will start/finish.
The text was updated successfully, but these errors were encountered: