Skip to content

Commit f9a9538

Browse files
authored
Fix firebase common (#483)
* fix common test * remove idea
1 parent c61f7b0 commit f9a9538

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

firebase-common/firebase-common.gradle

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -76,13 +76,13 @@ dependencies {
7676
androidTestImplementation 'com.android.support.test:runner:1.0.2'
7777
androidTestImplementation "com.google.truth:truth:$googleTruthVersion"
7878
androidTestImplementation 'org.mockito:mockito-core:2.21.0'
79-
androidTestImplementation 'com.linkedin.dexmaker:dexmaker:2.16.0'
80-
androidTestImplementation 'com.linkedin.dexmaker:dexmaker-mockito:2.16.0'
79+
androidTestImplementation 'com.linkedin.dexmaker:dexmaker:2.25.0'
80+
androidTestImplementation 'com.linkedin.dexmaker:dexmaker-mockito:2.25.0'
8181
androidTestImplementation ('com.google.firebase:firebase-auth:17.0.0') {
8282
exclude group: "com.google.firebase", module: "firebase-common"
8383
}
8484

85-
androidTestImplementation ('com.google.firebase:firebase-core:16.0.4') {
85+
androidTestImplementation ('com.google.firebase:firebase-core:16.0.9') {
8686
exclude group: "com.google.firebase", module: "firebase-common"
8787
}
8888

firebase-common/src/androidTest/java/com/google/firebase/FirebaseAppTest.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -142,9 +142,10 @@ public void testInitializeApp_shouldPublishVersionForFirebaseCommon() {
142142

143143
// After sorting the user agents are expected to be {"fire-android/", "fire-auth/x.y.z",
144144
// "fire-core/x.y.z", "test-component/1.2.3"}
145-
assertThat(actualUserAgent[0]).contains("fire-android");
146-
assertThat(actualUserAgent[1]).contains("fire-auth");
147-
assertThat(actualUserAgent[2]).contains("fire-core");
145+
assertThat(actualUserAgent[0]).contains("fire-analytics");
146+
assertThat(actualUserAgent[1]).contains("fire-android");
147+
assertThat(actualUserAgent[2]).contains("fire-auth");
148+
assertThat(actualUserAgent[3]).contains("fire-core");
148149
}
149150

150151
@Test

0 commit comments

Comments
 (0)