Skip to content

Commit f8e75fd

Browse files
committed
Adding param comments and checking if registration status is valid.
1 parent f16db3f commit f8e75fd

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

firebase-installations/src/main/java/com/google/firebase/installations/FirebaseInstallations.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -218,10 +218,10 @@ private Void registerAndSaveFid(PersistedFidEntry persistedFidEntry)
218218

219219
InstallationResponse installationResponse =
220220
serviceClient.createFirebaseInstallation(
221-
firebaseApp.getOptions().getApiKey(),
222-
persistedFidEntry.getFirebaseInstallationId(),
223-
firebaseApp.getOptions().getProjectId(),
224-
getApplicationId());
221+
/*apiKey= */ firebaseApp.getOptions().getApiKey(),
222+
/*fid= */ persistedFidEntry.getFirebaseInstallationId(),
223+
/*projectID= */ firebaseApp.getOptions().getProjectId(),
224+
/*appId= */ getApplicationId());
225225
persistedFid.insertOrUpdatePersistedFidEntry(
226226
PersistedFidEntry.builder()
227227
.setFirebaseInstallationId(persistedFidEntry.getFirebaseInstallationId())

firebase-installations/src/main/java/com/google/firebase/installations/local/PersistedFid.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,9 @@ public synchronized PersistedFidEntry readPersistedFidEntryValue() {
8282
prefs.getLong(getSharedPreferencesKey(TOKEN_CREATION_TIME_IN_SECONDS_KEY), 0);
8383
long expiresIn = prefs.getLong(getSharedPreferencesKey(EXPIRES_IN_SECONDS_KEY), 0);
8484

85-
if (fid == null || status == -1) {
85+
if (fid == null
86+
|| status == -1
87+
|| !(status >= 0 && status < RegistrationStatus.values().length)) {
8688
return null;
8789
}
8890

0 commit comments

Comments
 (0)