Skip to content

Commit f8d79c2

Browse files
committed
Feedback.
1 parent c193891 commit f8d79c2

File tree

3 files changed

+3
-2
lines changed

3 files changed

+3
-2
lines changed

firebase-firestore/src/main/java/com/google/firebase/firestore/local/LocalDocumentsView.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ Map<DocumentKey, OverlayedDocument> getOverlayedDocuments(
148148
* @param docs The documents to compute views for. It also has the base version of the documents.
149149
* @param overlays The overlays that need to be applied to the given base version of the
150150
* documents.
151-
* @param existenceStateChanged A set of documents that might there existence states changed. This
151+
* @param existenceStateChanged A set of documents whose existence states might have changed. This
152152
* is used to determine if we need to re-calculate overlays from mutation queues.
153153
* @return A map represents the local documents view.
154154
*/

firebase-firestore/src/main/java/com/google/firebase/firestore/model/mutation/MutationBatch.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -102,6 +102,7 @@ public void applyToRemoteDocument(MutableDocument document, MutationBatchResult
102102
/**
103103
* Computes the local view of a document given all the mutations in this batch.
104104
*
105+
* @param mutatedFields The document to be mutated.
105106
* @param mutatedFields Fields that are already mutated before applying the current one.
106107
* @return An {@link FieldMask} representing all the fields that are mutated.
107108
*/

firebase-firestore/src/main/java/com/google/firebase/firestore/remote/RemoteSerializer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -269,7 +269,7 @@ public com.google.firestore.v1.Write encodeMutation(Mutation mutation) {
269269
builder.setUpdate(encodeDocument(mutation.getKey(), ((SetMutation) mutation).getValue()));
270270
} else if (mutation instanceof PatchMutation) {
271271
builder.setUpdate(encodeDocument(mutation.getKey(), ((PatchMutation) mutation).getValue()));
272-
builder.setUpdateMask(encodeDocumentMask(((PatchMutation) mutation).getFieldMask()));
272+
builder.setUpdateMask(encodeDocumentMask((mutation.getFieldMask())));
273273
} else if (mutation instanceof DeleteMutation) {
274274
builder.setDelete(encodeKey(mutation.getKey()));
275275
} else if (mutation instanceof VerifyMutation) {

0 commit comments

Comments
 (0)