add RC wip

Author: leotianlizhan

firebase-perf/dev-app/dev-app.gradle

@@ -16,6 +16,7 @@ apply plugin: 'com.android.application'
 // Firebase performance plugin, the relevant dependency is specified in the "buildSrc/build-src.gradle"
 apply plugin: 'com.google.firebase.firebase-perf'
 apply plugin: com.google.firebase.gradle.plugins.ci.device.FirebaseTestLabPlugin
+apply plugin: 'com.google.gms.google-services'
 
 firebaseTestLab {
     device 'model=Pixel2,version=28,locale=en,orientation=portrait'

firebase-perf/src/main/java/com/google/firebase/perf/metrics/AppStartTrace.java

@@ -74,6 +74,7 @@ public class AppStartTrace implements ActivityLifecycleCallbacks {
   private boolean isRegisteredForLifecycleCallbacks = false;
   private final TransportManager transportManager;
   private final Clock clock;
+  private final ConfigResolver configResolver;
   private Context appContext;
   /**
    * The first time onCreate() of any activity is called, the activity is saved as launchActivity.
@@ -140,6 +141,7 @@ static AppStartTrace getInstance(TransportManager transportManager, Clock clock)
               new AppStartTrace(
                   transportManager,
                   clock,
+                  ConfigResolver.getInstance(),
                   new ThreadPoolExecutor(
                       CORE_POOL_SIZE,
                       MAX_POOL_SIZE,
@@ -155,9 +157,11 @@ static AppStartTrace getInstance(TransportManager transportManager, Clock clock)
   AppStartTrace(
       @NonNull TransportManager transportManager,
       @NonNull Clock clock,
+      @NonNull ConfigResolver configResolver,
       @NonNull ExecutorService executorService) {
     this.transportManager = transportManager;
     this.clock = clock;
+    this.configResolver = configResolver;
     this.executorService = executorService;
   }
 
@@ -244,7 +248,7 @@ public synchronized void onActivityResumed(Activity activity) {
     }
 
     // Shadow-launch experiment of new app start time
-    if (ConfigResolver.getInstance().getIsExperimentTTIDEnabled()) {
+    if (configResolver.getIsExperimentTTIDEnabled()) {
       View rootView = activity.findViewById(android.R.id.content);
       FirstDrawDoneListener.registerForNextDraw(rootView, this::recordFirstDrawDone);
     }

firebase-perf/src/test/java/com/google/firebase/perf/metrics/AppStartTraceTest.java

@@ -14,19 +14,27 @@
 
 package com.google.firebase.perf.metrics;
 
+import static com.google.common.truth.Truth.assertThat;
 import static com.google.firebase.perf.util.TimerTest.getElapsedRealtimeMicros;
+import static org.mockito.ArgumentMatchers.isA;
 import static org.mockito.Mockito.doAnswer;
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.times;
 import static org.mockito.Mockito.verify;
 import static org.mockito.Mockito.when;
 import static org.mockito.MockitoAnnotations.initMocks;
+import static org.robolectric.Shadows.shadowOf;
 
 import android.app.Activity;
 import android.content.pm.ProviderInfo;
 import android.os.Bundle;
+import android.os.Looper;
+import android.os.Process;
+import android.os.SystemClock;
+import android.view.View;
 import androidx.test.core.app.ApplicationProvider;
 import com.google.firebase.perf.FirebasePerformanceTestBase;
+import com.google.firebase.perf.config.ConfigResolver;
 import com.google.firebase.perf.provider.FirebasePerfProvider;
 import com.google.firebase.perf.session.SessionManager;
 import com.google.firebase.perf.transport.TransportManager;
@@ -36,6 +44,7 @@
 import com.google.firebase.perf.v1.ApplicationProcessState;
 import com.google.firebase.perf.v1.TraceMetric;
 import com.google.testing.timing.FakeScheduledExecutorService;
+import java.time.Duration;
 import java.util.concurrent.TimeUnit;
 import org.junit.After;
 import org.junit.Assert;
@@ -48,13 +57,18 @@
 import org.mockito.invocation.InvocationOnMock;
 import org.mockito.stubbing.Answer;
 import org.robolectric.RobolectricTestRunner;
+import org.robolectric.annotation.Config;
+import org.robolectric.annotation.LooperMode;
+import org.robolectric.shadows.ShadowSystemClock;
 
 /** Unit tests for {@link AppStartTrace}. */
 @RunWith(RobolectricTestRunner.class)
+@LooperMode(LooperMode.Mode.PAUSED)
 public class AppStartTraceTest extends FirebasePerformanceTestBase {
 
   @Mock private Clock clock;
   @Mock private TransportManager transportManager;
+  @Mock private ConfigResolver configResolver;
   @Mock private Activity activity1;
   @Mock private Activity activity2;
   @Mock private Bundle bundle;
@@ -94,7 +108,8 @@ public void reset() {
   @Test
   public void testLaunchActivity() {
     FakeScheduledExecutorService fakeExecutorService = new FakeScheduledExecutorService();
-    AppStartTrace trace = new AppStartTrace(transportManager, clock, fakeExecutorService);
+    AppStartTrace trace =
+        new AppStartTrace(transportManager, clock, configResolver, fakeExecutorService);
     // first activity goes through onCreate()->onStart()->onResume() state change.
     currentTime = 1;
     trace.onActivityCreated(activity1, bundle);
@@ -171,7 +186,8 @@ private void verifyFinalState(
   @Test
   public void testInterleavedActivity() {
     FakeScheduledExecutorService fakeExecutorService = new FakeScheduledExecutorService();
-    AppStartTrace trace = new AppStartTrace(transportManager, clock, fakeExecutorService);
+    AppStartTrace trace =
+        new AppStartTrace(transportManager, clock, configResolver, fakeExecutorService);
     // first activity onCreate()
     currentTime = 1;
     trace.onActivityCreated(activity1, bundle);
@@ -206,7 +222,8 @@ public void testInterleavedActivity() {
   @Test
   public void testDelayedAppStart() {
     FakeScheduledExecutorService fakeExecutorService = new FakeScheduledExecutorService();
-    AppStartTrace trace = new AppStartTrace(transportManager, clock, fakeExecutorService);
+    AppStartTrace trace =
+        new AppStartTrace(transportManager, clock, configResolver, fakeExecutorService);
     // Delays activity creation after 1 minute from app start time.
     currentTime = appStart.getMicros() + TimeUnit.MINUTES.toMicros(1) + 1;
     trace.onActivityCreated(activity1, bundle);
@@ -227,7 +244,8 @@ public void testDelayedAppStart() {
   @Test
   public void testStartFromBackground() {
     FakeScheduledExecutorService fakeExecutorService = new FakeScheduledExecutorService();
-    AppStartTrace trace = new AppStartTrace(transportManager, clock, fakeExecutorService);
+    AppStartTrace trace =
+        new AppStartTrace(transportManager, clock, configResolver, fakeExecutorService);
     trace.setIsStartFromBackground();
     trace.onActivityCreated(activity1, bundle);
     Assert.assertNull(trace.getOnCreateTime());
@@ -261,4 +279,38 @@ public void testFirebasePerfProviderOnAttachInfo_initializesGaugeCollection() {
     Assert.assertEquals(oldSessionId, SessionManager.getInstance().perfSession().sessionId());
     verify(mockPerfSession, times(2)).isGaugeAndEventCollectionEnabled();
   }
+
+  @Test
+  @Config(sdk = 26)
+  public void timeToInitialDisplay_isLogged() {
+    when(clock.getTime()).thenCallRealMethod(); // Use robolectric shadows to manipulate time
+    long appStartTime = TimeUnit.MILLISECONDS.toMicros(Process.getStartElapsedRealtime());
+    View testView = new View(ApplicationProvider.getApplicationContext());
+    when(activity1.findViewById(android.R.id.content)).thenReturn(testView);
+    when(configResolver.getIsExperimentTTIDEnabled()).thenReturn(true);
+    FakeScheduledExecutorService fakeExecutorService = new FakeScheduledExecutorService();
+    AppStartTrace trace =
+        new AppStartTrace(transportManager, clock, configResolver, fakeExecutorService);
+
+    ShadowSystemClock.advanceBy(Duration.ofMillis(1000));
+    long resumeTime = TimeUnit.NANOSECONDS.toMicros(SystemClock.elapsedRealtimeNanos());
+    trace.onActivityCreated(activity1, bundle);
+    trace.onActivityStarted(activity1);
+    trace.onActivityResumed(activity1);
+    fakeExecutorService.runAll();
+    verify(transportManager, times(1))
+        .log(isA(TraceMetric.class), isA(ApplicationProcessState.class));
+    ShadowSystemClock.advanceBy(Duration.ofMillis(1000));
+    long drawTime = TimeUnit.NANOSECONDS.toMicros(SystemClock.elapsedRealtimeNanos());
+    testView.getViewTreeObserver().dispatchOnDraw();
+    shadowOf(Looper.getMainLooper()).idle();
+    fakeExecutorService.runNext();
+    verify(transportManager, times(2))
+        .log(traceArgumentCaptor.capture(), isA(ApplicationProcessState.class));
+
+    TraceMetric ttid = traceArgumentCaptor.getValue();
+    assertThat(ttid.getName()).isEqualTo("_experiment_as_ttid");
+    assertThat(ttid.getDurationUs()).isNotEqualTo(resumeTime - appStartTime);
+    assertThat(ttid.getDurationUs()).isEqualTo(drawTime - appStartTime);
+  }
 }