Resolve comments

Author: mrober

firebase-crashlytics/src/main/java/com/google/firebase/crashlytics/internal/send/ReportQueue.java

@@ -125,7 +125,7 @@ public void flushScheduledReportsIfAble() {
     CountDownLatch latch = new CountDownLatch(1);
     new Thread(
             () -> {
-              ForcedSender.sendBlockingWithPriority(transport, Priority.HIGHEST);
+              ForcedSender.sendBlocking(transport, Priority.HIGHEST);
               latch.countDown();
             })
         .start();

transport/transport-runtime/src/main/java/com/google/android/datatransport/runtime/ForcedSender.java

@@ -1,3 +1,17 @@
+// Copyright 2022 Google LLC
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
 package com.google.android.datatransport.runtime;
 
 import android.annotation.SuppressLint;
@@ -11,10 +25,10 @@
         "TransportRuntime is not a realtime delivery system, don't use unless you absolutely must.")
 public final class ForcedSender {
   @WorkerThread
-  public static void sendBlockingWithPriority(Transport<?> transport, Priority priority) {
+  public static void sendBlocking(Transport<?> transport, Priority priority) {
     @SuppressLint("DiscouragedApi")
     TransportContext context = getTransportContextOrThrow(transport).withPriority(priority);
-    TransportRuntime.getInstance().getUploader().upload(context, 1, () -> {});
+    TransportRuntime.getInstance().getUploader().logAndUpdateState(context, 1);
   }
 
   private static TransportContext getTransportContextOrThrow(Transport<?> transport) {
@@ -23,4 +37,6 @@ private static TransportContext getTransportContextOrThrow(Transport<?> transpor
     }
     throw new IllegalArgumentException("Expected instance of TransportImpl.");
   }
+
+  private ForcedSender() {}
 }

transport/transport-runtime/src/main/java/com/google/android/datatransport/runtime/scheduling/jobscheduling/Uploader.java

@@ -111,7 +111,7 @@ public void upload(TransportContext transportContext, int attemptNumber, Runnabl
         });
   }
 
-  BackendResponse logAndUpdateState(TransportContext transportContext, int attemptNumber) {
+  public BackendResponse logAndUpdateState(TransportContext transportContext, int attemptNumber) {
     TransportBackend backend = backendRegistry.get(transportContext.getBackendName());
     long maxNextRequestWaitMillis = 0;