Skip to content

Commit ee13f03

Browse files
authored
Enable CHANGELOG check globally (#4084)
* Enable CHANGELOG check globally * Simplify conditional.
1 parent 7ca9c98 commit ee13f03

File tree

1 file changed

+4
-19
lines changed

1 file changed

+4
-19
lines changed

ci/danger/Dangerfile

Lines changed: 4 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -71,28 +71,13 @@ def has_sdk_changes()
7171
}
7272
end
7373

74-
tester_team = [
75-
'rlazo',
76-
'vkryachko',
77-
'yifanyang',
78-
'VinayGuthal',
79-
'davidmotson',
80-
'daymxn',
81-
'emilypgoogle'
82-
]
83-
84-
is_enabled = true if tester_team.include? github.pr_author
85-
8674
### Actions
8775

8876
# Warn if a changelog is left out on a non-trivial PR that has modified
8977
# SDK source files.
9078
#
91-
# TODO: remove the `is_enabled` after tests are complete
92-
if is_enabled && has_sdk_changes()
93-
if !has_changelog_changes && !declared_trivial
94-
warning = "Did you forget to add a changelog entry? (Add the 'no-changelog'"\
95-
" label to the PR to silence this warning.)"
96-
warn(warning)
97-
end
79+
if has_sdk_changes() && !has_changelog_changes && !declared_trivial
80+
warning = "Did you forget to add a changelog entry? (Add the 'no-changelog'"\
81+
" label to the PR to silence this warning.)"
82+
warn(warning)
9883
end

0 commit comments

Comments
 (0)