Skip to content

Commit e934350

Browse files
Refactor: Move network classes from util to remote (#476)
1 parent 63496cd commit e934350

File tree

7 files changed

+11
-14
lines changed

7 files changed

+11
-14
lines changed

firebase-firestore/src/main/java/com/google/firebase/firestore/remote/AbstractStream.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,6 @@
2323
import com.google.firebase.firestore.util.AsyncQueue.DelayedTask;
2424
import com.google.firebase.firestore.util.AsyncQueue.TimerId;
2525
import com.google.firebase.firestore.util.ExponentialBackoff;
26-
import com.google.firebase.firestore.util.FirestoreChannel;
27-
import com.google.firebase.firestore.util.IncomingStreamObserver;
2826
import com.google.firebase.firestore.util.Logger;
2927
import io.grpc.ClientCall;
3028
import io.grpc.Metadata;

firebase-firestore/src/main/java/com/google/firebase/firestore/remote/Datastore.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@
2626
import com.google.firebase.firestore.model.mutation.Mutation;
2727
import com.google.firebase.firestore.model.mutation.MutationResult;
2828
import com.google.firebase.firestore.util.AsyncQueue;
29-
import com.google.firebase.firestore.util.FirestoreChannel;
3029
import com.google.firebase.firestore.util.Supplier;
3130
import com.google.firestore.v1.BatchGetDocumentsRequest;
3231
import com.google.firestore.v1.BatchGetDocumentsResponse;
@@ -61,7 +60,7 @@
6160
public class Datastore {
6261

6362
/** Set of lowercase, white-listed headers for logging purposes. */
64-
public static final Set<String> WHITE_LISTED_HEADERS =
63+
static final Set<String> WHITE_LISTED_HEADERS =
6564
new HashSet<>(
6665
Arrays.asList(
6766
"date",

firebase-firestore/src/main/java/com/google/firebase/firestore/remote/FirestoreCallCredentials.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
import java.util.concurrent.Executor;
2525

2626
/** CallCredentials that applies any authorization headers. */
27-
public final class FirestoreCallCredentials extends CallCredentials2 {
27+
final class FirestoreCallCredentials extends CallCredentials2 {
2828

2929
private static final String LOG_TAG = "FirestoreCallCredentials";
3030

@@ -33,7 +33,7 @@ public final class FirestoreCallCredentials extends CallCredentials2 {
3333

3434
private final CredentialsProvider credentialsProvider;
3535

36-
public FirestoreCallCredentials(CredentialsProvider provider) {
36+
FirestoreCallCredentials(CredentialsProvider provider) {
3737
credentialsProvider = provider;
3838
}
3939

firebase-firestore/src/main/java/com/google/firebase/firestore/util/FirestoreChannel.java renamed to firebase-firestore/src/main/java/com/google/firebase/firestore/remote/FirestoreChannel.java

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
// See the License for the specific language governing permissions and
1313
// limitations under the License.
1414

15-
package com.google.firebase.firestore.util;
15+
package com.google.firebase.firestore.remote;
1616

1717
import com.google.android.gms.tasks.Task;
1818
import com.google.android.gms.tasks.TaskCompletionSource;
@@ -21,7 +21,9 @@
2121
import com.google.firebase.firestore.FirebaseFirestoreException.Code;
2222
import com.google.firebase.firestore.auth.CredentialsProvider;
2323
import com.google.firebase.firestore.model.DatabaseId;
24-
import com.google.firebase.firestore.remote.FirestoreCallCredentials;
24+
import com.google.firebase.firestore.util.AsyncQueue;
25+
import com.google.firebase.firestore.util.Logger;
26+
import com.google.firebase.firestore.util.Util;
2527
import com.google.firestore.v1.FirestoreGrpc;
2628
import com.google.firestore.v1.FirestoreGrpc.FirestoreStub;
2729
import io.grpc.CallOptions;
@@ -38,7 +40,7 @@
3840
* Wrapper class around io.grpc.Channel that adds headers, exception handling and simplifies
3941
* invoking RPCs.
4042
*/
41-
public class FirestoreChannel {
43+
class FirestoreChannel {
4244

4345
private static final Metadata.Key<String> X_GOOG_API_CLIENT_HEADER =
4446
Metadata.Key.of("x-goog-api-client", Metadata.ASCII_STRING_MARSHALLER);
@@ -66,7 +68,7 @@ public class FirestoreChannel {
6668
/** The value to use as resource prefix header. */
6769
private final String resourcePrefixValue;
6870

69-
public FirestoreChannel(
71+
FirestoreChannel(
7072
AsyncQueue asyncQueue,
7173
CredentialsProvider credentialsProvider,
7274
ManagedChannel grpcChannel,

firebase-firestore/src/main/java/com/google/firebase/firestore/util/IncomingStreamObserver.java renamed to firebase-firestore/src/main/java/com/google/firebase/firestore/remote/IncomingStreamObserver.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,13 +12,13 @@
1212
// See the License for the specific language governing permissions and
1313
// limitations under the License.
1414

15-
package com.google.firebase.firestore.util;
15+
package com.google.firebase.firestore.remote;
1616

1717
import io.grpc.Metadata;
1818
import io.grpc.Status;
1919

2020
/** Interface used for incoming/receiving gRPC streams. */
21-
public interface IncomingStreamObserver<RespT> {
21+
interface IncomingStreamObserver<RespT> {
2222
/** Headers were received for this stream. */
2323
void onHeaders(Metadata headers);
2424

firebase-firestore/src/main/java/com/google/firebase/firestore/remote/WatchStream.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
import com.google.firebase.firestore.model.SnapshotVersion;
2121
import com.google.firebase.firestore.util.AsyncQueue;
2222
import com.google.firebase.firestore.util.AsyncQueue.TimerId;
23-
import com.google.firebase.firestore.util.FirestoreChannel;
2423
import com.google.firestore.v1.FirestoreGrpc;
2524
import com.google.firestore.v1.ListenRequest;
2625
import com.google.firestore.v1.ListenResponse;

firebase-firestore/src/main/java/com/google/firebase/firestore/remote/WriteStream.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
import com.google.firebase.firestore.model.mutation.MutationResult;
2323
import com.google.firebase.firestore.util.AsyncQueue;
2424
import com.google.firebase.firestore.util.AsyncQueue.TimerId;
25-
import com.google.firebase.firestore.util.FirestoreChannel;
2625
import com.google.firestore.v1.FirestoreGrpc;
2726
import com.google.firestore.v1.WriteRequest;
2827
import com.google.firestore.v1.WriteResponse;

0 commit comments

Comments
 (0)