Skip to content

Commit e29d5b6

Browse files
vkryachkorlazo
andauthored
Apply suggestions from code review
Co-authored-by: Rodrigo Lazo <[email protected]>
1 parent 8468b3e commit e29d5b6

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

contributor-docs/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Contributor documentation
22

3-
This site is a collection of docs and best practices useful to contributors to Firebase Android SDKs.
3+
This site is a collection of docs and best practices for contributors to Firebase Android SDKs.
44
It describes how Firebase works on Android and provides guidance on how to build/maintain a Firebase SDK.
55

66
## New to Firebase?

contributor-docs/how_firebase_works.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,24 +10,24 @@ One of the biggest strengths for Firebase clients is the ease of integration. In
1010
* `Firebase Performance` automatically tracks app startup time, all network requests and screen performance
1111
* `Crashlytics` automatically captures all application crashes, ANRs and non-fatals
1212

13-
The ability to initialize and start operating automatically is a core feature of Firebase that makes onboarding and adoption very simple. However with this advantage comes a great responsibility to keep the application snappy and not to slow down application startup for 3p developers as it can stand in the way of user adoption for the application.
13+
This feature makes onboarding and adoption very simple. However, comes with the great responsibility of keeping the application snappy. We shouldn't slow down application startup for 3p developers as it can stand in the way of user adoption of their application.
1414

1515
### Automatic Inter-Product Discovery
1616

17-
In addition to initializing automatically, when present together in an application, Firebase products can detect each other’s presence and automatically provide additional functionality to the developer, e.g.:
17+
When present together in an application, Firebase products can detect each other and automatically provide additional functionality to the developer, e.g.:
1818

1919
* `Firestore` automatically detects `Auth` and `AppCheck` to protect read/write access to the database
20-
* `Crashlytics` integrates with `Analytics`, when it’s available, to provide additional insights into the application behavior and enables safe app rollouts
20+
* `Crashlytics` integrates with `Analytics`, when available, to provide additional insights into the application behavior and enables safe app rollouts
2121

2222
## FirebaseApp at the Core of Firebase
2323

24-
Regardless of what Firebase SDKs are present in the app, the main initialization point of Firebase is `FirebaseApp` it acts as a container for all SDKs, manages their configuration, initialization and lifecycle.
24+
Regardless of what Firebase SDKs are present in the app, the main initialization point of Firebase is `FirebaseApp`. It acts as a container for all SDKs, manages their configuration, initialization and lifecycle.
2525

2626
### Initialization
2727

28-
`FirebaseApp` gets initialized with the help of `FirebaseApp#initializeApp()`, this happens [automatically at app startup](https://firebase.blog/posts/2016/12/how-does-firebase-initialize-on-android) or manually by the developer.
28+
`FirebaseApp` gets initialized with the help of `FirebaseApp#initializeApp()`. This happens [automatically at app startup](https://firebase.blog/posts/2016/12/how-does-firebase-initialize-on-android) or manually by the developer.
2929

30-
When that happens `FirebaseApp` discovers all Firebase SDKs present in the app, determines the dependency graph between products(for inter-product functionality) and initializes `eager` products that need to start immediately, e.g. `Crashlytics` and `FirebasePerformance`.
30+
During initialization, `FirebaseApp` discovers all Firebase SDKs present in the app, determines the dependency graph between products(for inter-product functionality) and initializes `eager` products that need to start immediately, e.g. `Crashlytics` and `FirebasePerformance`.
3131

3232
### Firebase Configuration
3333

contributor-docs/onboarding/new_sdk.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,14 @@ parent: Onboarding
55
# Creating a new Firebase SDK
66

77
Want to create a new SDK in
8-
[Firebase/firebase-android-sdk](https://github.com/firebase/firebase-android-sdk)?
8+
[firebase/firebase-android-sdk](https://github.com/firebase/firebase-android-sdk)?
99
Read on.
1010

1111
{:toc}
1212

1313
## Repository layout and Gradle
1414

15-
[Firebase/firebase-android-sdk](https://github.com/firebase/firebase-android-sdk)
15+
[firebase/firebase-android-sdk](https://github.com/firebase/firebase-android-sdk)
1616
uses a multi-project Gradle build to organize the different libraries it hosts.
1717
As a consequence, each project/product within this repo is hosted under its own
1818
subdirectory with its respective build file(s).

0 commit comments

Comments
 (0)