Merge pull request #64 from FirebasePrivate/gsoltis/no-lru

Port no-lru tag for spec tests

Author: Greg Soltis

firebase-firestore/src/test/java/com/google/firebase/firestore/spec/MemorySpecTest.java

@@ -2,6 +2,7 @@
 
 import com.google.firebase.firestore.local.Persistence;
 import com.google.firebase.firestore.local.PersistenceTestHelpers;
+import java.util.Set;
 import org.junit.runner.RunWith;
 import org.robolectric.RobolectricTestRunner;
 import org.robolectric.annotation.Config;
@@ -14,4 +15,10 @@ public class MemorySpecTest extends SpecTestCase {
   Persistence getPersistence() {
     return PersistenceTestHelpers.createMemoryPersistence();
   }
+
+  @Override
+  protected boolean shouldRun(Set<String> tags) {
+    // There are currently no tags which disable memory persistence tests.
+    return true;
+  }
 }

firebase-firestore/src/test/java/com/google/firebase/firestore/spec/SQLiteSpecTest.java

@@ -2,6 +2,7 @@
 
 import com.google.firebase.firestore.local.Persistence;
 import com.google.firebase.firestore.local.PersistenceTestHelpers;
+import java.util.Set;
 import org.junit.runner.RunWith;
 import org.robolectric.RobolectricTestRunner;
 import org.robolectric.annotation.Config;
@@ -10,8 +11,15 @@
 @Config(manifest = Config.NONE)
 public class SQLiteSpecTest extends SpecTestCase {
 
+  private static final String NO_LRU_TAG = "no-lru";
+
   @Override
   Persistence getPersistence() {
     return PersistenceTestHelpers.createSQLitePersistence();
   }
+
+  @Override
+  protected boolean shouldRun(Set<String> tags) {
+    return !tags.contains(NO_LRU_TAG);
+  }
 }

firebase-firestore/src/test/java/com/google/firebase/firestore/spec/SpecTestCase.java

@@ -184,6 +184,8 @@ public static void log(String line) {
 
   abstract Persistence getPersistence();
 
+  protected abstract boolean shouldRun(Set<String> tags);
+
   private void specSetUp(JSONObject config) {
     log("    Clearing all state.");
 
@@ -1010,13 +1012,13 @@ private static boolean anyTestsAreMarkedExclusive(JSONObject fileJSON) throws JS
   }
 
   /** Called before executing each test to see if it should be run. */
-  private static boolean shouldRunTest(Set<String> tags) throws JSONException {
+  private boolean shouldRunTest(Set<String> tags) throws JSONException {
     for (String tag : tags) {
       if (DISABLED_TAGS.contains(tag)) {
         return false;
       }
     }
-    return true;
+    return shouldRun(tags);
   }
 
   private static Set<String> getTestTags(JSONObject testJSON) throws JSONException {