Fireperf: fix unchecked operations in e2e FirebasePerformanceFragmentScreenTracesTest (#3637)

* attempt to fix unchecked operations

* gjf

* spelling

Author: leotianlizhan

firebase-perf/e2e-app/src/androidTest/java/com/google/firebase/testing/fireperf/FirebasePerformanceFragmentScreenTracesTest.java

@@ -19,18 +19,17 @@
 import static androidx.test.espresso.matcher.ViewMatchers.withId;
 import static com.google.common.truth.Truth.assertThat;
 
-import android.app.Activity;
 import androidx.annotation.NonNull;
-import androidx.appcompat.app.AppCompatActivity;
 import androidx.fragment.app.Fragment;
+import androidx.fragment.app.FragmentActivity;
 import androidx.fragment.app.FragmentManager;
 import androidx.lifecycle.Lifecycle.State;
 import androidx.navigation.NavController;
 import androidx.navigation.Navigation;
 import androidx.test.core.app.ActivityScenario;
 import androidx.test.ext.junit.rules.ActivityScenarioRule;
+import androidx.test.ext.junit.runners.AndroidJUnit4;
 import androidx.test.filters.MediumTest;
-import androidx.test.runner.AndroidJUnit4;
 import com.google.firebase.testing.fireperf.ui.fast.FastFragment;
 import com.google.firebase.testing.fireperf.ui.home.HomeFragment;
 import com.google.firebase.testing.fireperf.ui.slow.SlowFragment;
@@ -48,16 +47,16 @@
 public class FirebasePerformanceFragmentScreenTracesTest {
 
   @Rule
-  public ActivityScenarioRule<FragmentActivity> activityRule =
-      new ActivityScenarioRule<>(FragmentActivity.class);
+  public ActivityScenarioRule<FirebasePerfFragmentsActivity> activityRule =
+      new ActivityScenarioRule<>(FirebasePerfFragmentsActivity.class);
 
   @Test
   public void scrollAndCycleThroughAllFragments() throws InterruptedException {
     activityRule
         .getScenario()
         .onActivity(
             activity -> {
-              ((AppCompatActivity) activity)
+              ((FragmentActivity) activity)
                   .getSupportFragmentManager()
                   .registerFragmentLifecycleCallbacks(
                       new FragmentManager.FragmentLifecycleCallbacks() {
@@ -99,15 +98,16 @@ private synchronized void notifyNavigationLock() {
     notify();
   }
 
-  static class NavigateAction implements ActivityScenario.ActivityAction {
+  static class NavigateAction
+      implements ActivityScenario.ActivityAction<FirebasePerfFragmentsActivity> {
     private final int destinationId;
 
     public NavigateAction(int destinationId) {
       this.destinationId = destinationId;
     }
 
     @Override
-    public void perform(Activity activity) {
+    public void perform(FirebasePerfFragmentsActivity activity) {
       NavController navController =
           Navigation.findNavController(activity, R.id.nav_host_fragment_activity_fragment);
       navController.navigate(destinationId);

firebase-perf/e2e-app/src/main/AndroidManifest.xml

@@ -12,7 +12,7 @@
         android:usesCleartextTraffic="true"
         tools:ignore="HardcodedDebugMode,UnusedAttribute">
         <activity
-            android:name=".FragmentActivity"
+            android:name=".FirebasePerfFragmentsActivity"
             android:label="@string/title_activity_fragment"
             android:theme="@style/Theme.MaterialComponents.DayNight.DarkActionBar" />
         <activity

firebase-perf/e2e-app/src/main/java/com/google/firebase/testing/fireperf/FragmentActivity.java renamed to firebase-perf/e2e-app/src/main/java/com/google/firebase/testing/fireperf/FirebasePerfFragmentsActivity.java

@@ -21,7 +21,7 @@
 import androidx.navigation.ui.NavigationUI;
 import com.google.android.material.bottomnavigation.BottomNavigationView;
 
-public class FragmentActivity extends AppCompatActivity {
+public class FirebasePerfFragmentsActivity extends AppCompatActivity {
   @Override
   protected void onCreate(Bundle savedInstanceState) {
     super.onCreate(savedInstanceState);

firebase-perf/e2e-app/src/main/res/values/strings.xml

@@ -1,7 +1,7 @@
 <!-- Copyright 2021 Google Inc. All Rights Reserved. -->
 
 <resources>
-    <string name="title_activity_fragment">FragmentActivity</string>
+    <string name="title_activity_fragment">FirebasePerfFragmentsActivity</string>
     <string name="title_home">Home</string>
     <string name="title_fast">Fast</string>
     <string name="title_slow">Slow</string>