Skip to content

Commit dca1bb6

Browse files
committed
Factor out document creation
1 parent f2b101d commit dca1bb6

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

buildSrc/src/main/java/com/google/firebase/gradle/plugins/GmavenHelper.kt

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -38,34 +38,34 @@ class GmavenHelper(val groupId: String, val artifactId: String) {
3838
}
3939

4040
fun hasReleasedVersion(version: String): Boolean {
41-
try {
42-
val groupIdAsPath = groupId.replace(".", "/")
43-
val mavenMetadataUrl = "${GMAVEN_ROOT}/${groupIdAsPath}/${artifactId}/maven-metadata.xml"
44-
val factory: DocumentBuilderFactory = DocumentBuilderFactory.newInstance()
45-
val builder: DocumentBuilder = factory.newDocumentBuilder()
46-
val doc: Document = builder.parse(URL(mavenMetadataUrl).openStream())
47-
doc.documentElement.normalize()
41+
val doc: Document? = getDocument()
42+
if (doc != null) {
4843
val versions = doc.getElementsByTagName("version")
4944
for (i in 0..versions.length - 1) {
5045
if (versions.item(i).textContent == version) {
5146
return true
5247
}
5348
}
54-
} catch (e: FileNotFoundException) {}
49+
}
5550
return false
5651
}
5752

5853
fun getLatestReleasedVersion(): String {
54+
val doc: Document? = getDocument()
55+
return doc?.getElementsByTagName("latest")?.item(0)?.getTextContent() ?: ""
56+
}
57+
58+
fun getDocument(): Document? {
5959
try {
6060
val groupIdAsPath = groupId.replace(".", "/")
6161
val mavenMetadataUrl = "${GMAVEN_ROOT}/${groupIdAsPath}/${artifactId}/maven-metadata.xml"
6262
val factory: DocumentBuilderFactory = DocumentBuilderFactory.newInstance()
6363
val builder: DocumentBuilder = factory.newDocumentBuilder()
6464
val doc: Document = builder.parse(URL(mavenMetadataUrl).openStream())
6565
doc.documentElement.normalize()
66-
return doc.getElementsByTagName("latest").item(0).getTextContent()
66+
return doc
6767
} catch (e: FileNotFoundException) {
68-
return ""
68+
return null
6969
}
7070
}
7171
}

0 commit comments

Comments
 (0)