Skip to content

Commit d65656b

Browse files
Use androidX Nullable
1 parent db9a9a7 commit d65656b

File tree

6 files changed

+9
-8
lines changed

6 files changed

+9
-8
lines changed

firebase-firestore/src/main/java/com/google/firebase/firestore/local/IndexFreeQueryEngine.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616

1717
import static com.google.firebase.firestore.util.Assert.hardAssert;
1818

19+
import androidx.annotation.Nullable;
1920
import com.google.firebase.database.collection.ImmutableSortedMap;
2021
import com.google.firebase.database.collection.ImmutableSortedSet;
2122
import com.google.firebase.firestore.core.Query;
@@ -25,7 +26,6 @@
2526
import com.google.firebase.firestore.model.MaybeDocument;
2627
import com.google.firebase.firestore.model.SnapshotVersion;
2728
import java.util.Map;
28-
import javax.annotation.Nullable;
2929

3030
/**
3131
* A query engine that takes advantage of the target document mapping in the QueryCache. The

firebase-firestore/src/main/java/com/google/firebase/firestore/local/QueryEngine.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,13 @@
1414

1515
package com.google.firebase.firestore.local;
1616

17+
import androidx.annotation.Nullable;
1718
import com.google.firebase.database.collection.ImmutableSortedMap;
1819
import com.google.firebase.database.collection.ImmutableSortedSet;
1920
import com.google.firebase.firestore.core.Query;
2021
import com.google.firebase.firestore.model.Document;
2122
import com.google.firebase.firestore.model.DocumentKey;
2223
import com.google.firebase.firestore.model.MaybeDocument;
23-
import javax.annotation.Nullable;
2424

2525
/**
2626
* Represents a query engine capable of performing queries over the local document cache. You must

firebase-firestore/src/main/java/com/google/firebase/firestore/local/SimpleQueryEngine.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,14 +16,14 @@
1616

1717
import static com.google.firebase.firestore.util.Assert.hardAssert;
1818

19+
import androidx.annotation.Nullable;
1920
import com.google.firebase.database.collection.ImmutableSortedMap;
2021
import com.google.firebase.database.collection.ImmutableSortedSet;
2122
import com.google.firebase.firestore.core.Query;
2223
import com.google.firebase.firestore.model.Document;
2324
import com.google.firebase.firestore.model.DocumentKey;
2425
import com.google.firebase.firestore.model.MaybeDocument;
2526
import com.google.firebase.firestore.model.SnapshotVersion;
26-
import javax.annotation.Nullable;
2727

2828
/**
2929
* A naive implementation of QueryEngine that just loads all the documents in the queried collection

firebase-firestore/src/test/java/com/google/firebase/firestore/local/IndexFreeQueryEngineTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -148,11 +148,11 @@ private void addUpdatedResult(Document doc) {
148148
}
149149

150150
private ImmutableSortedMap<DocumentKey, Document> runQuery(
151-
Query query, QueryData queryData, boolean expectIndexFree) {
151+
Query query, QueryData queryData, boolean expectIndexFree) {
152152
expectIndexFreeExecution = expectIndexFree;
153153
ImmutableSortedSet<DocumentKey> remoteKeys =
154-
new ImmutableSortedSet<>(
155-
new ArrayList<>(existingQueryResults.keySet()), DocumentKey.comparator());
154+
new ImmutableSortedSet<>(
155+
new ArrayList<>(existingQueryResults.keySet()), DocumentKey.comparator());
156156
return queryEngine.getDocumentsMatchingQuery(query, queryData, remoteKeys);
157157
}
158158

firebase-firestore/src/test/java/com/google/firebase/firestore/local/LocalStoreTestCase.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1201,7 +1201,8 @@ public void testQueriesIncludeDocumentsFromOtherQueries() {
12011201

12021202
@Test
12031203
public void testQueriesFilterDocumentsThatNoLongerMatch() {
1204-
// This test verifies that documents that once matched a query are post-filtered if they no longer match the query filter.
1204+
// This test verifies that documents that once matched a query are post-filtered if they no
1205+
// longer match the query filter.
12051206
if (garbageCollectorIsEager()) {
12061207
return;
12071208
}

firebase-firestore/src/test/java/com/google/firebase/firestore/spec/QueryEvent.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,10 @@
1414

1515
package com.google.firebase.firestore.spec;
1616

17+
import androidx.annotation.Nullable;
1718
import com.google.firebase.firestore.FirebaseFirestoreException;
1819
import com.google.firebase.firestore.core.Query;
1920
import com.google.firebase.firestore.core.ViewSnapshot;
20-
import javax.annotation.Nullable;
2121

2222
/** Object that contains exactly one of either a view snapshot or an error for the given query. */
2323
public class QueryEvent {

0 commit comments

Comments
 (0)