Skip to content

Commit d5b05f2

Browse files
authored
Firestore: Fix comment in testDoesNotAutoCreateIndexesWhenIndexLookUpIsExpensive (#5219)
1 parent 6b2a90f commit d5b05f2

File tree

1 file changed

+1
-4
lines changed

1 file changed

+1
-4
lines changed

firebase-firestore/src/test/java/com/google/firebase/firestore/local/SQLiteLocalStoreTest.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -444,9 +444,7 @@ public void testDoesNotAutoCreateIndexesWhenIndexLookUpIsExpensive() {
444444
applyRemoteEvent(
445445
addedRemoteEvent(doc("coll/e", 10, map("array", Arrays.asList(2, 0, 8))), targetId));
446446

447-
// First time query runs without indexes.
448-
// Based on current heuristic, collection document counts (5) > 2 * resultSize (2).
449-
// Full matched index should be created.
447+
// SDK will not create indexes since relative read cost is too large.
450448
executeQuery(query);
451449
assertRemoteDocumentsRead(/* byKey= */ 0, /* byCollection= */ 2);
452450
assertQueryReturned("coll/a", "coll/e");
@@ -479,7 +477,6 @@ public void testIndexAutoCreationWorksWhenBackfillerRunsHalfway() {
479477
// Based on current heuristic, collection document counts (5) > 2 * resultSize (2).
480478
// Full matched index should be created.
481479
executeQuery(query);
482-
// Only document a matches the result
483480
assertRemoteDocumentsRead(/* byKey= */ 0, /* byCollection= */ 2);
484481
assertQueryReturned("coll/a", "coll/e");
485482

0 commit comments

Comments
 (0)