Port crv to github (#4004)

* update component

* update

Author: VinayGuthal

firebase-components/firebase-components.gradle

@@ -44,7 +44,7 @@ android {
 dependencies {
     implementation project(':firebase-annotations')
     implementation 'androidx.annotation:annotation:1.1.0'
-
+    implementation "com.google.errorprone:error_prone_annotations:2.9.0"
     testImplementation 'androidx.test:runner:1.2.0'
     testImplementation 'androidx.test.ext:junit:1.1.1'
     testImplementation "org.robolectric:robolectric:$robolectricVersion"

firebase-components/src/main/java/com/google/firebase/components/Component.java

@@ -17,6 +17,7 @@
 import androidx.annotation.IntDef;
 import androidx.annotation.NonNull;
 import androidx.annotation.Nullable;
+import com.google.errorprone.annotations.CanIgnoreReturnValue;
 import java.lang.annotation.Retention;
 import java.lang.annotation.RetentionPolicy;
 import java.util.Arrays;
@@ -265,6 +266,7 @@ public Builder<T> name(@NonNull String name) {
     }
 
     /** Add a {@link Dependency} to the {@link Component} being built. */
+    @CanIgnoreReturnValue
     public Builder<T> add(Dependency dependency) {
       Preconditions.checkNotNull(dependency, "Null dependency");
       validateInterface(dependency.getInterface());
@@ -273,21 +275,25 @@ public Builder<T> add(Dependency dependency) {
     }
 
     /** Make the {@link Component} initialize upon startup. */
+    @CanIgnoreReturnValue
     public Builder<T> alwaysEager() {
       return setInstantiation(Instantiation.ALWAYS_EAGER);
     }
 
     /** Make the component initialize upon startup in default app. */
+    @CanIgnoreReturnValue
     public Builder<T> eagerInDefaultApp() {
       return setInstantiation(Instantiation.EAGER_IN_DEFAULT_APP);
     }
 
     /** Make the {@link Component} eligible to publish events of provided eventType. */
+    @CanIgnoreReturnValue
     public Builder<T> publishes(Class<?> eventType) {
       publishedEvents.add(eventType);
       return this;
     }
 
+    @CanIgnoreReturnValue
     private Builder<T> setInstantiation(@Instantiation int instantiation) {
       Preconditions.checkState(
           this.instantiation == Instantiation.LAZY, "Instantiation type has already been set.");
@@ -302,11 +308,13 @@ private void validateInterface(Class<?> anInterface) {
     }
 
     /** Set the factory that will be used to initialize the {@link Component}. */
+    @CanIgnoreReturnValue
     public Builder<T> factory(ComponentFactory<T> value) {
       factory = Preconditions.checkNotNull(value, "Null factory");
       return this;
     }
 
+    @CanIgnoreReturnValue
     private Builder<T> intoSet() {
       type = ComponentType.SET;
       return this;

firebase-components/src/main/java/com/google/firebase/components/ComponentRuntime.java

@@ -18,6 +18,7 @@
 import androidx.annotation.RestrictTo;
 import androidx.annotation.RestrictTo.Scope;
 import androidx.annotation.VisibleForTesting;
+import com.google.errorprone.annotations.CanIgnoreReturnValue;
 import com.google.firebase.dynamicloading.ComponentLoader;
 import com.google.firebase.events.Publisher;
 import com.google.firebase.events.Subscriber;
@@ -358,21 +359,25 @@ public static final class Builder {
       this.defaultExecutor = defaultExecutor;
     }
 
+    @CanIgnoreReturnValue
     public Builder addLazyComponentRegistrars(Collection<Provider<ComponentRegistrar>> registrars) {
       this.lazyRegistrars.addAll(registrars);
       return this;
     }
 
+    @CanIgnoreReturnValue
     public Builder addComponentRegistrar(ComponentRegistrar registrar) {
       this.lazyRegistrars.add(() -> registrar);
       return this;
     }
 
+    @CanIgnoreReturnValue
     public Builder addComponent(Component<?> component) {
       this.additionalComponents.add(component);
       return this;
     }
 
+    @CanIgnoreReturnValue
     public Builder setProcessor(ComponentRegistrarProcessor processor) {
       this.componentRegistrarProcessor = processor;
       return this;

firebase-components/src/main/java/com/google/firebase/components/Preconditions.java

@@ -14,6 +14,8 @@
 
 package com.google.firebase.components;
 
+import com.google.errorprone.annotations.CanIgnoreReturnValue;
+
 public final class Preconditions {
 
   public static void checkArgument(boolean expression, String errorMessage) {
@@ -22,13 +24,15 @@ public static void checkArgument(boolean expression, String errorMessage) {
     }
   }
 
+  @CanIgnoreReturnValue
   public static <T> T checkNotNull(T reference) {
     if (reference == null) {
       throw new NullPointerException();
     }
     return reference;
   }
 
+  @CanIgnoreReturnValue
   public static <T> T checkNotNull(T reference, String errorMessage) {
     if (reference == null) {
       throw new NullPointerException(errorMessage);