Skip to content

Commit cba4bff

Browse files
committed
Make try { } catches less wide
1 parent 365d773 commit cba4bff

File tree

2 files changed

+11
-15
lines changed

2 files changed

+11
-15
lines changed

firebase-crashlytics/src/main/java/com/google/firebase/crashlytics/internal/common/NativeSessionFileGzipper.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,8 @@ static void processNativeSessions(File nativeSessionDirectory, List<NativeSessio
3737
}
3838
gzipInputStream(
3939
inputStream, new File(nativeSessionDirectory, stream.getReportsEndpointFilename()));
40-
} catch (Exception e) {
41-
// Skip invalid files.
40+
} catch (IOException e) {
41+
// Skip invalid files, and we'll clean them up later.
4242
} finally {
4343
CommonUtils.closeQuietly(inputStream);
4444
}

firebase-crashlytics/src/main/java/com/google/firebase/crashlytics/internal/common/SessionReportingCoordinator.java

Lines changed: 9 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -126,22 +126,18 @@ public void persistNonFatalEvent(Throwable event, Thread thread, long timestamp)
126126

127127
public void finalizeSessionWithNativeEvent(
128128
String sessionId, @NonNull List<NativeSessionFile> nativeSessionFiles) {
129-
try {
130-
FilesPayload.Builder filesPayloadBuilder = FilesPayload.builder();
131-
ArrayList<FilesPayload.File> nativeFiles = new ArrayList<>();
132-
for (NativeSessionFile nativeSessionFile : nativeSessionFiles) {
133-
FilesPayload.File filePayload = nativeSessionFile.asFilePayload();
134-
if (filePayload != null) {
135-
nativeFiles.add(filePayload);
136-
}
129+
FilesPayload.Builder filesPayloadBuilder = FilesPayload.builder();
130+
ArrayList<FilesPayload.File> nativeFiles = new ArrayList<>();
131+
for (NativeSessionFile nativeSessionFile : nativeSessionFiles) {
132+
FilesPayload.File filePayload = nativeSessionFile.asFilePayload();
133+
if (filePayload != null) {
134+
nativeFiles.add(filePayload);
137135
}
136+
}
138137

139-
filesPayloadBuilder.setFiles(ImmutableList.from(nativeFiles));
138+
filesPayloadBuilder.setFiles(ImmutableList.from(nativeFiles));
140139

141-
reportPersistence.finalizeSessionWithNativeEvent(sessionId, filesPayloadBuilder.build());
142-
} catch (Exception e) {
143-
throw new RuntimeException(e);
144-
}
140+
reportPersistence.finalizeSessionWithNativeEvent(sessionId, filesPayloadBuilder.build());
145141
}
146142

147143
public void persistUserId() {

0 commit comments

Comments
 (0)