Skip to content

Commit c9cf94d

Browse files
committed
Add TODO for constructing SharedPreferences on a @background thread
1 parent 5ad6f03 commit c9cf94d

File tree

1 file changed

+3
-0
lines changed
  • firebase-appdistribution/src/main/java/com/google/firebase/appdistribution/impl

1 file changed

+3
-0
lines changed

firebase-appdistribution/src/main/java/com/google/firebase/appdistribution/impl/SignInStorage.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,9 @@ class SignInStorage {
3030
this.signInSharedPreferences =
3131
new Lazy(
3232
() ->
33+
// TODO(lkellogg): This constructs a SharedPreferences object, which touches disk
34+
// and therefore should be run on a @Background executor. This could ideally be
35+
// done by a new shared component.
3336
applicationContext.getSharedPreferences(
3437
SIGNIN_PREFERENCES_NAME, Context.MODE_PRIVATE));
3538
}

0 commit comments

Comments
 (0)