Migrate core libraries to Gradle Kotlin DSL. (#4452)

* Migrate core libraries to Gradle Kotlin DSL.

* update

* Add functions, fix tests

* fix docs

* fix functions ktx minSdk version.

* Apply suggestions from code review

Co-authored-by: Rodrigo Lazo <[email protected]>

Co-authored-by: Rodrigo Lazo <[email protected]>

Author: vkryachko

appcheck/firebase-appcheck-debug-testing/firebase-appcheck-debug-testing.gradle

@@ -31,6 +31,7 @@ android {
         targetSdkVersion project.targetSdkVersion
         minSdkVersion project.minSdkVersion
         versionName version
+        multiDexEnabled = true
         testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
         testInstrumentationRunnerArgument "firebaseAppCheckDebugSecret", System.getenv("FIREBASE_APP_CHECK_DEBUG_SECRET") ?: ''
     }

appcheck/firebase-appcheck/firebase-appcheck.gradle

@@ -29,6 +29,7 @@ android {
     defaultConfig {
         targetSdkVersion project.targetSdkVersion
         minSdkVersion project.minSdkVersion
+        multiDexEnabled = true
         versionName version
         testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
     }

buildSrc/src/main/java/com/google/firebase/gradle/plugins/ProjectUtils.kt

@@ -32,7 +32,15 @@ fun toBoolean(value: Any?): Boolean {
 
 /** Finds or creates the javadocClasspath [Configuration]. */
 val Project.javadocConfig: Configuration
-  get() = configurations.findByName("javadocClasspath") ?: configurations.create("javadocClasspath")
+  get() =
+    configurations.findByName("javadocClasspath")
+      ?: configurations.create("javadocClasspath").also { javadocClasspath ->
+        configurations.all {
+          if (name == "compileOnly") {
+            javadocClasspath.extendsFrom(this)
+          }
+        }
+      }
 
 /**
  * Finds or creates the dackkaArtifacts [Configuration].

contributor-docs/best_practices/dependency_injection.md

@@ -47,7 +47,7 @@ plugins {
 
 dependencies {
     implementation(libs.javax.inject)
-    vendor(libs.dagger) {
+    vendor(libs.dagger.dagger) {
         exclude group: "javax.inject", module: "javax.inject"
     }
     annotationProcessor(libs.dagger.compiler)

firebase-annotations/firebase-annotations.gradle renamed to firebase-annotations/firebase-annotations.gradle.kts

@@ -13,23 +13,22 @@
 // limitations under the License.
 
 plugins {
-    id 'firebase-java-library'
+  id("firebase-java-library")
 }
 
 firebaseLibrary {
-    publishSources = true
-    publishJavadoc = false
+  publishSources = true
+  publishJavadoc = false
 }
 
 java {
-    sourceCompatibility JavaVersion.VERSION_1_8
-    targetCompatibility JavaVersion.VERSION_1_8
+  sourceCompatibility = JavaVersion.VERSION_1_8
+  targetCompatibility = JavaVersion.VERSION_1_8
 }
-
-tasks.withType(JavaCompile) {
-    options.compilerArgs << "-Werror"
+tasks.withType<JavaCompile> {
+  options.compilerArgs.add("-Werror")
 }
 
 dependencies {
-    implementation 'javax.inject:javax.inject:1'
+  implementation(libs.javax.inject)
 }

firebase-common/data-collection-tests/data-collection-tests.gradle

@@ -0,0 +1,47 @@
+// Copyright 2022 Google LLC
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+plugins {
+    id("com.android.application")
+}
+
+android {
+  val targetSdkVersion : Int by rootProject
+  val minSdkVersion : Int by rootProject
+  compileSdk = targetSdkVersion
+  defaultConfig {
+    minSdk = minSdkVersion
+    targetSdk = targetSdkVersion
+    multiDexEnabled = true
+    testInstrumentationRunner = "androidx.test.runner.AndroidJUnitRunner"
+  }
+  compileOptions {
+    sourceCompatibility = JavaVersion.VERSION_1_8
+    targetCompatibility = JavaVersion.VERSION_1_8
+  }
+  testOptions.unitTests.isIncludeAndroidResources = true
+}
+
+dependencies {
+    implementation(project(":firebase-common"))
+    implementation(project(":firebase-components"))
+    testImplementation(libs.androidx.test.runner)
+    testImplementation(libs.androidx.test.junit)
+    testImplementation(libs.robolectric)
+    testImplementation(libs.autovalue.annotations)
+    testImplementation(libs.junit)
+    testImplementation(libs.truth)
+    testImplementation(libs.mockito.core)
+    testImplementation(libs.androidx.core)
+}

firebase-common/data-collection-tests/data-collection-tests.gradle.kts

@@ -0,0 +1,84 @@
+// Copyright 2022 Google LLC
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+plugins {
+    id("firebase-library")
+}
+
+firebaseLibrary {
+    testLab.enabled = true
+    publishSources = true
+}
+
+android {
+  val targetSdkVersion : Int by rootProject
+  val minSdkVersion : Int by rootProject
+
+  compileSdk = targetSdkVersion
+  defaultConfig {
+    minSdk = minSdkVersion
+    targetSdk = targetSdkVersion
+    multiDexEnabled = true
+    testInstrumentationRunner = "androidx.test.runner.AndroidJUnitRunner"
+    consumerProguardFiles("proguard.txt")
+  }
+  sourceSets {
+    getByName("androidTest") {
+      java.srcDirs("src/testUtil")
+    }
+    getByName("test") {
+      java.srcDirs("src/testUtil")
+    }
+  }
+  compileOptions {
+    sourceCompatibility = JavaVersion.VERSION_1_8
+    targetCompatibility = JavaVersion.VERSION_1_8
+  }
+  testOptions.unitTests.isIncludeAndroidResources = true
+}
+
+dependencies {
+    implementation(project(":firebase-annotations"))
+    implementation(project(":firebase-components"))
+    implementation(libs.androidx.futures)
+    implementation(libs.playservices.basement)
+    implementation(libs.playservices.tasks)
+
+    annotationProcessor(libs.autovalue)
+
+    compileOnly(libs.autovalue.annotations)
+    compileOnly(libs.findbugs.jsr305)
+    // needed for Kotlin detection to compile, but not necessarily present at runtime.
+    compileOnly(libs.kotlin.stdlib)
+
+    // FirebaseApp references storage, so storage needs to be on classpath when dokka runs.
+    javadocClasspath(project(":firebase-storage"))
+
+    testImplementation(libs.androidx.test.junit)
+    testImplementation(libs.androidx.test.junit)
+    testImplementation(libs.androidx.test.runner)
+    testImplementation(libs.junit)
+    testImplementation(libs.mockito.core)
+    testImplementation(libs.org.json)
+    testImplementation(libs.robolectric)
+    testImplementation(libs.truth)
+
+    androidTestImplementation(libs.androidx.test.junit)
+    androidTestImplementation(libs.androidx.test.runner)
+    androidTestImplementation(libs.junit)
+    androidTestImplementation(libs.mockito.core)
+    androidTestImplementation(libs.mockito.dexmaker)
+    androidTestImplementation(libs.truth)
+    androidTestImplementation(project(":integ-testing"))
+}