Make default sampling rates for when RC fetch failed 1/1000 typical (#5071)

* Make default sampling rates for when RC fetch failed 1/1000 typical default

* Fix tests

* Change log message to warn and link to support

Author: mrober

firebase-perf/src/main/java/com/google/firebase/perf/config/ConfigurationConstants.java

@@ -154,8 +154,8 @@ protected Double getDefault() {
 
     @Override
     protected Double getDefaultOnRcFetchFail() {
-      // Reduce the typical default by 2 orders of magnitude.
-      return getDefault() / 100;
+      // Reduce the typical default by 3 orders of magnitude.
+      return getDefault() / 1000;
     }
 
     @Override
@@ -193,8 +193,8 @@ protected Double getDefault() {
 
     @Override
     protected Double getDefaultOnRcFetchFail() {
-      // Reduce the typical default by 2 orders of magnitude.
-      return getDefault() / 100;
+      // Reduce the typical default by 3 orders of magnitude.
+      return getDefault() / 1000;
     }
 
     @Override
@@ -579,8 +579,8 @@ protected Double getDefault() {
 
     @Override
     protected Double getDefaultOnRcFetchFail() {
-      // Reduce the typical default by 2 orders of magnitude.
-      return getDefault() / 100;
+      // Reduce the typical default by 3 orders of magnitude.
+      return getDefault() / 1000;
     }
 
     @Override

firebase-perf/src/main/java/com/google/firebase/perf/config/RemoteConfigManager.java

@@ -347,7 +347,9 @@ private void triggerFirebaseRemoteConfigFetchAndActivateOnSuccessfulFetch() {
         .addOnFailureListener(
             executor,
             ex -> {
-              logger.debug("Remote config fetch failed: %s", ex);
+              logger.warn(
+                  "Call to Remote Config failed: %s. This may cause a degraded experience with Firebase Performance. Please reach out to Firebase Support https://firebase.google.com/support/",
+                  ex);
               firebaseRemoteConfigLastFetchTimestampMs = FETCH_NEVER_HAPPENED_TIMESTAMP_MS;
             });
   }

firebase-perf/src/test/java/com/google/firebase/perf/config/ConfigResolverTest.java

@@ -1685,7 +1685,7 @@ public void getTraceSamplingRate_remoteConfigFetchFailed_returnsRCFailureDefault
         .thenReturn(Optional.absent());
     when(mockRemoteConfigManager.isLastFetchFailed()).thenReturn(true);
 
-    assertThat(testConfigResolver.getTraceSamplingRate()).isEqualTo(1.00 / 100);
+    assertThat(testConfigResolver.getTraceSamplingRate()).isEqualTo(1.00 / 1000);
   }
 
   @Test
@@ -1757,7 +1757,7 @@ public void getNetworkRequestSamplingRate_remoteConfigFetchFailed_returnsRCFailu
         .thenReturn(Optional.absent());
     when(mockRemoteConfigManager.isLastFetchFailed()).thenReturn(true);
 
-    assertThat(testConfigResolver.getNetworkRequestSamplingRate()).isEqualTo(1.00 / 100);
+    assertThat(testConfigResolver.getNetworkRequestSamplingRate()).isEqualTo(1.00 / 1000);
   }
 
   @Test
@@ -1989,7 +1989,7 @@ public void getSessionsSamplingRate_remoteConfigFetchFailed_returnsRCFailureDefa
         .thenReturn(Optional.absent());
     when(mockRemoteConfigManager.isLastFetchFailed()).thenReturn(true);
 
-    assertThat(testConfigResolver.getSessionsSamplingRate()).isEqualTo(0.01 / 100);
+    assertThat(testConfigResolver.getSessionsSamplingRate()).isEqualTo(0.01 / 1000);
   }
 
   @Test

firebase-perf/src/test/java/com/google/firebase/perf/config/ConfigurationConstantsTest.java

@@ -155,7 +155,7 @@ public void getInstance_TraceSamplingRate_validateConstants() {
     TraceSamplingRate configFlag = TraceSamplingRate.getInstance();
 
     assertThat(configFlag.getDefault()).isEqualTo(1.00);
-    assertThat(configFlag.getDefaultOnRcFetchFail()).isEqualTo(0.01);
+    assertThat(configFlag.getDefaultOnRcFetchFail()).isEqualTo(0.001);
     assertThat(configFlag.getDeviceCacheFlag())
         .isEqualTo("com.google.firebase.perf.TraceSamplingRate");
     assertThat(configFlag.getRemoteConfigFlag()).isEqualTo("fpr_vc_trace_sampling_rate");
@@ -167,7 +167,7 @@ public void getInstance_NetworkRequestSamplingRate_validateConstants() {
     NetworkRequestSamplingRate configFlag = NetworkRequestSamplingRate.getInstance();
 
     assertThat(configFlag.getDefault()).isEqualTo(1.00);
-    assertThat(configFlag.getDefaultOnRcFetchFail()).isEqualTo(0.01);
+    assertThat(configFlag.getDefaultOnRcFetchFail()).isEqualTo(0.001);
     assertThat(configFlag.getDeviceCacheFlag())
         .isEqualTo("com.google.firebase.perf.NetworkRequestSamplingRate");
     assertThat(configFlag.getRemoteConfigFlag()).isEqualTo("fpr_vc_network_request_sampling_rate");
@@ -179,7 +179,7 @@ public void getInstance_SessionsSamplingRate_validateConstants() {
     SessionsSamplingRate configFlag = SessionsSamplingRate.getInstance();
 
     assertThat(configFlag.getDefault()).isEqualTo(0.01);
-    assertThat(configFlag.getDefaultOnRcFetchFail()).isEqualTo(0.0001);
+    assertThat(configFlag.getDefaultOnRcFetchFail()).isEqualTo(0.00001);
     assertThat(configFlag.getDeviceCacheFlag())
         .isEqualTo("com.google.firebase.perf.SessionSamplingRate");
     assertThat(configFlag.getRemoteConfigFlag()).isEqualTo("fpr_vc_session_sampling_rate");