Skip to content

Commit bc56f21

Browse files
committed
resolve comments
1 parent e8937ac commit bc56f21

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

firebase-firestore/src/test/java/com/google/firebase/firestore/local/LocalSerializerTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -405,7 +405,7 @@ public void testEncodesTargetData() {
405405
}
406406

407407
@Test
408-
public void localSerializerDropsExpectedCountInTargetData() {
408+
public void localSerializerShouldDropExpectedCountInTargetData() {
409409
Query query = TestUtil.query("room");
410410
int targetId = 42;
411411
long sequenceNumber = 10;

firebase-firestore/src/test/java/com/google/firebase/firestore/remote/RemoteEventTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -459,7 +459,7 @@ public void testExistenceFilterMismatchClearsTarget() {
459459
}
460460

461461
@Test
462-
public void existenceFilterMismatchWithBloomFilterSuccess() {
462+
public void existenceFilterMismatchWithSuccessfulBloomFilterApplication() {
463463
Map<Integer, TargetData> targetMap = activeQueries(1, 2);
464464

465465
MutableDocument doc1 = doc("docs/1", 1, map("value", 1));
@@ -551,10 +551,10 @@ public void existenceFilterMismatchWithBloomFilterFalsePositiveResult() {
551551
TargetChange mapping2 = targetChange(resumeToken, false, null, null, null);
552552
assertEquals(mapping2, event.getTargetChanges().get(2));
553553

554-
// This BloomFilter will return true on both MightContain(doc1) and MightContain(doc2).
554+
// With this BloomFilter, mightContain() will return true for all documents.
555555
BitSequence.Builder bitSequence = BitSequence.newBuilder();
556556
bitSequence.setPadding(7);
557-
bitSequence.setBitmap(ByteString.copyFrom(new byte[] {0x42, (byte) 0xFE}));
557+
bitSequence.setBitmap(ByteString.copyFrom(new byte[] {(byte) 0xFF, (byte) 0xFF}));
558558
com.google.firestore.v1.BloomFilter.Builder bloomFilter = BloomFilter.newBuilder();
559559
bloomFilter.setBits(bitSequence);
560560
bloomFilter.setHashCount(33);

firebase-firestore/src/test/java/com/google/firebase/firestore/remote/RemoteSerializerTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1221,7 +1221,7 @@ public void encodesExpectedCountWhenReadTimeIsPresent() {
12211221
}
12221222

12231223
@Test
1224-
public void ignoresExpectedCountWithoutResumeTokenOrReadTime() {
1224+
public void shouldIgnoreExpectedCountWithoutResumeTokenOrReadTime() {
12251225
Query q = Query.atPath(ResourcePath.fromString("docs"));
12261226
TargetData targetData =
12271227
new TargetData(q.toTarget(), 1, 2, QueryPurpose.LISTEN).withExpectedCount(42);

0 commit comments

Comments
 (0)